Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove voice from build script #3277

Closed
Jasper-Bekkers opened this issue Nov 20, 2020 · 5 comments · Fixed by #3307
Closed

Remove voice from build script #3277

Jasper-Bekkers opened this issue Nov 20, 2020 · 5 comments · Fixed by #3307
Assignees

Comments

@Jasper-Bekkers
Copy link

Please, please, remove the voice from the build scripts.

@Jasper-Bekkers
Copy link
Author

While we're on the subject of improving the build system, please also don't add shortcuts to my desktop.

@expipiplus1
Copy link
Contributor

What is "the voice"?

@Jasper-Bekkers
Copy link
Author

Jasper-Bekkers commented Nov 27, 2020

By default the build scripts that are in the documentation call into hctspeak.js; https://github.com/microsoft/DirectXShaderCompiler/blob/master/utils/hct/hctspeak.js and announce that build has been completed (or has failed). Typically at whatever volume it thinks is acceptable; something that's scared me on multiple occasions. It would be really nice if this feature is default-off / opt-in by default.

Notice that the build scripts for other platforms don't do this (and, even better, follow regular cmake workflows instead of relying on a custom build script).

@hekota
Copy link
Member

hekota commented Dec 1, 2020

Hello Jasper, there is -dont-speak option on the hctbuild script, would that work for you?

@Jasper-Bekkers
Copy link
Author

If that option exists, should it be the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants