dts resolve to CJS entry dts instead of ESM entry dts

[loynoir]

Bug Report

🔎 Search Terms

• dts resolve priority
• conditional exports

🕗 Version & Regression Information

• This is a crash
• This changed between versions ______ and _______
• This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
• I was unable to test this on prior versions because _______

⏯ Playground Link

Playground link with relevant code

💻 Code

==> reproduce1.cjs <==
require('@sinclair/typebox')

==> reproduce2.mjs <==
await import('@sinclair/typebox')

==> /path/to/node_modules/@sinclair/typebox/cjs/package.json <==
{"type":"commonjs"}

==> /path/to/node_modules/@sinclair/typebox/esm/package.json <==
{"type":"module"}

https://github.com/loynoir/typebox/blob/feat-esm/package.json#L13-L56

🙁 Actual behavior

reproduce1.cjs

require('@sinclair/typebox')

dts resolve to node_modules/@sinclair/typebox/cjs/typebox.d.ts

reproduce2.mjs

await import('@sinclair/typebox')

dts resolve to node_modules/@sinclair/typebox/cjs/typebox.d.ts

🙂 Expected behavior

reproduce1.cjs

require('@sinclair/typebox')

dts resolve to node_modules/@sinclair/typebox/cjs/typebox.d.ts

reproduce2.mjs

await import('@sinclair/typebox')

dts resolve to node_modules/@sinclair/typebox/esm/typebox.d.ts

Related

sinclairzx81/typebox#400 (comment)

#53948

#52593

[RyanCavanaugh]

ESM resolution is not broken across the board.

It sounds like you have moduleResolution set to "node" or "classic"; it should be "node16".

Please create a complete repro (including tsconfig.json) in a new issue if you have found a bug. Thanks!

[fatcerberus]

"node12"

Preeetttyyy sure that won’t work. 😉
AFAIR node12 never shipped and node16 is the lowest (barring legacy node), right?

[RyanCavanaugh]

😵‍💫 thanks

[loynoir]

Please create a complete repro (including tsconfig.json) in a new issue if you have found a bug. Thanks!

Close in favor of #53958