From 4270ad232e0ee344745e985b619ace447d5ab1f0 Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 8 Apr 2022 19:20:02 -0400 Subject: [PATCH 01/13] Bump typings and build agents to use node 16 --- .github/workflows/ci.yml | 2 +- Dockerfile | 11 ++++++----- docs/building-web.md | 2 +- package.json | 8 ++++++-- pipeline/install-node-prerequisites.yaml | 4 ++-- 5 files changed, 16 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 80f32e892e1..6641b14be9a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ on: env: # Keep this in sync with /pipeline/install-node-prerequisites.yaml - NODE_VERSION: 14.19.0 + NODE_VERSION: 16.14.2 jobs: build: diff --git a/Dockerfile b/Dockerfile index 971dff38f44..f7fda54a9fc 100644 --- a/Dockerfile +++ b/Dockerfile @@ -10,14 +10,15 @@ FROM mcr.microsoft.com/playwright:v1.20.2-focal AS setup USER root # We need to update certificates before we can successfully update and install node -# This is a workaround for https://github.com/nodesource/distributions/issues/1266 -# Downgrading from nodejs 16.3.0 to 14.* is both for consistency with our other build -# environments and a workaround for https://github.com/nodejs/node/issues/39019 +# This is a workaround for https://github.com/nodesource/distributions/issues/1266 +# +# We pin nodejs 16.x instead of accepting Playwright's default for consistency with +# our other build environments. RUN apt-get update ; apt-get install ca-certificates \ && apt-get update \ && apt-get install -y curl && \ - curl -fsSL https://deb.nodesource.com/setup_14.x | bash - && \ - apt-get install -y --allow-downgrades nodejs=14.* && \ + curl -fsSL https://deb.nodesource.com/setup_16.x | bash - && \ + apt-get install -y --allow-downgrades nodejs=16.* && \ rm -rf /var/lib/apt/lists/* RUN npm install -g yarn@1.22.10 diff --git a/docs/building-web.md b/docs/building-web.md index 7291b86341f..c63321d6362 100644 --- a/docs/building-web.md +++ b/docs/building-web.md @@ -13,7 +13,7 @@ This document describes how to build and test Accessibility Insights for Web (th You will need the following tools installed: -- [Node](https://nodejs.org) >= 14.19.0 (check by running `node --version`) - This is the version being enforced on our builds +- [Node](https://nodejs.org) >= 16.14.2 (check by running `node --version`) - This is the version being enforced on our builds - [Yarn](https://yarnpkg.com/getting-started/install) >= 1.22.10 (check by running `yarn --version`) - Note: There is a [known name collision](https://github.com/yarnpkg/yarn/issues/673) between Yarn package manager and Hadoop YARN. If you have Hadoop YARN installed, replace `yarn` with `yarnpkg` in the commands below. - **macOS only** [Xcode](https://wilsonmar.github.io/xcode/#XcodeInstall). This is needed when installing some dev dependencies (like spectron). After installing Xcode, run the following commands from a command terminal: diff --git a/package.json b/package.json index 0f1ff833c49..61f81cf7d13 100644 --- a/package.json +++ b/package.json @@ -102,7 +102,7 @@ "@types/jsdom": "^16.2.14", "@types/lodash": "^4.14.181", "@types/luxon": "^2.3.1", - "@types/node": "^14.18.12", + "@types/node": "^16.11.7", "@types/react": "^16.14.24", "@types/react-copy-to-clipboard": "^5.0.2", "@types/react-dom": "^16.9.14", @@ -197,7 +197,7 @@ "webextension-polyfill-ts": "^0.26.0" }, "resolutions": { - "@types/node": "^14.14.6", + "@types/node": "^16.11.7", "dot-prop": "^5.2.0", "kind-of": "^6.0.3", "minimist": "^1.2.3", @@ -206,5 +206,9 @@ "nth-check": ">=2.0.1", "tar": ">=6.1.9", "plist": ">=3.0.5" + }, + "volta": { + "node": "16.x", + "yarn": "1.x" } } diff --git a/pipeline/install-node-prerequisites.yaml b/pipeline/install-node-prerequisites.yaml index 0e3dd25a1f6..b1cd2a6188d 100644 --- a/pipeline/install-node-prerequisites.yaml +++ b/pipeline/install-node-prerequisites.yaml @@ -4,8 +4,8 @@ steps: - task: NodeTool@0 inputs: # Keep this in sync with /.github/workflows/ci.yml - versionSpec: '14.19.0' - displayName: use node 14.19.0 + versionSpec: '16.14.2' + displayName: use node 16.14.2 timeoutInMinutes: 2 - script: npm install yarn@1.22.10 -g From 723a765f7fb1588d97a34e223ed4893f8645b6ba Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 8 Apr 2022 19:21:32 -0400 Subject: [PATCH 02/13] Drop volta pinning --- package.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/package.json b/package.json index 61f81cf7d13..c8e6acc7783 100644 --- a/package.json +++ b/package.json @@ -206,9 +206,5 @@ "nth-check": ">=2.0.1", "tar": ">=6.1.9", "plist": ">=3.0.5" - }, - "volta": { - "node": "16.x", - "yarn": "1.x" } } From 9162895d90de2bd8d166b8c6e8e21958b65a1e48 Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 8 Apr 2022 19:27:36 -0400 Subject: [PATCH 03/13] Update lockfile --- yarn.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/yarn.lock b/yarn.lock index ac8b734fa5a..4d0b3af6153 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2592,10 +2592,10 @@ resolved "https://registry.yarnpkg.com/@types/ms/-/ms-0.7.31.tgz#31b7ca6407128a3d2bbc27fe2d21b345397f6197" integrity sha512-iiUgKzV9AuaEkZqkOLDIvlQiL6ltuZd9tGcW3gwpnX8JbuiuhFlEGmmFXEXkN50Cvq7Os88IY2v0dkDqXYWVgA== -"@types/node@*", "@types/node@16.9.1", "@types/node@^14.14.6", "@types/node@^14.18.12", "@types/node@^14.6.2": - version "14.18.12" - resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.12.tgz#0d4557fd3b94497d793efd4e7d92df2f83b4ef24" - integrity sha512-q4jlIR71hUpWTnGhXWcakgkZeHa3CCjcQcnuzU8M891BAWA2jHiziiWEPEkdS5pFsz7H9HJiy8BrK7tBRNrY7A== +"@types/node@*", "@types/node@16.9.1", "@types/node@^14.6.2", "@types/node@^16.11.7": + version "16.11.26" + resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.26.tgz#63d204d136c9916fb4dcd1b50f9740fe86884e47" + integrity sha512-GZ7bu5A6+4DtG7q9GsoHXy3ALcgeIHP4NnL0Vv2wu0uUB/yQex26v0tf6/na1mm0+bS9Uw+0DFex7aaKr2qawQ== "@types/normalize-package-data@^2.4.0": version "2.4.1" From c47ac5eba61d562c14efc29541d0f93bfc31234e Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 8 Apr 2022 20:07:06 -0400 Subject: [PATCH 04/13] Shard unit tests to address perf regression --- .github/workflows/ci.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6641b14be9a..37398a0d6f1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,8 +57,16 @@ jobs: timeout-minutes: 5 unit-tests: + name: unit-tests (${{ strategy.job-index }}/${{ strategy.job-total }}) runs-on: ubuntu-20.04 env: { PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 } + strategy: + fail-fast: false + matrix: + test-filename-prefix-pattern: + - "[a-k]" + - "[^a-k]" + steps: - uses: actions/checkout@v2 timeout-minutes: 2 @@ -86,22 +94,19 @@ jobs: - run: yarn install --frozen-lockfile --prefer-offline timeout-minutes: 10 - - run: yarn test --ci + - run: yarn test --ci --testMatch="/**/${{ matrix.test-filename-prefix-pattern }}*.test.ts" timeout-minutes: 10 - name: upload artifact unit-tests-results uses: actions/upload-artifact@v2 if: ${{ always() }} with: - name: unit-tests-results + name: unit-tests-${{ strategy.job-index }}-results path: | test-results/unit/junit.xml test-results/unit/coverage/cobertura-coverage.xml timeout-minutes: 5 - - run: yarn publish-code-coverage - timeout-minutes: 3 - lints: runs-on: ubuntu-20.04 env: { PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 } From 1a49377516edf193b3dab17dc9e56d76f1a5565a Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 8 Apr 2022 20:07:46 -0400 Subject: [PATCH 05/13] Try improving job name --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 37398a0d6f1..ffaf5e82ef1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,7 @@ jobs: timeout-minutes: 5 unit-tests: - name: unit-tests (${{ strategy.job-index }}/${{ strategy.job-total }}) + name: unit-tests (${{ strategy.job-index + 1 }}/${{ strategy.job-total }}) runs-on: ubuntu-20.04 env: { PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 } strategy: From 21f4acfac3a84112a48584f646b051550295fd98 Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 8 Apr 2022 20:11:10 -0400 Subject: [PATCH 06/13] fix job naming syntax --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ffaf5e82ef1..a1717834db4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,7 @@ jobs: timeout-minutes: 5 unit-tests: - name: unit-tests (${{ strategy.job-index + 1 }}/${{ strategy.job-total }}) + name: unit-tests-${{ strategy.job-index }} runs-on: ubuntu-20.04 env: { PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 } strategy: @@ -165,7 +165,7 @@ jobs: timeout-minutes: 10 e2e-web-tests: - name: e2e-web-tests (${{ strategy.job-index }}/${{ strategy.job-total }}) + name: e2e-web-tests-${{ strategy.job-index }} runs-on: ubuntu-20.04 container: mcr.microsoft.com/playwright:v1.20.2-focal strategy: @@ -223,7 +223,7 @@ jobs: timeout-minutes: 3 e2e-unified-tests: - name: e2e-unified-tests (${{ strategy.job-index }}/${{ strategy.job-total }}) + name: e2e-unified-tests-${{ strategy.job-index }} runs-on: ubuntu-20.04 env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 From e435ee56be6aaaebc835f13e6626c54fbbdb5cd8 Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 29 Apr 2022 16:17:30 -0400 Subject: [PATCH 07/13] Use cobetura-merge to re-enable code coverage --- .github/workflows/ci.yml | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index efbc5b3324c..a2e9fa223c8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -105,6 +105,41 @@ jobs: test-results/unit/coverage/cobertura-coverage.xml timeout-minutes: 5 + publish-code-coverage: + needs: + - 'unit-tests (1/2)' + - 'unit-tests (2/2)' + runs-on: ubuntu-20.04 + steps: + - uses: actions/download-artifact@v3 + with: + name: unit-tests-1-results + path: unit-tests-1-results + timeout-minutes: 2 + + - uses: actions/download-artifact@v3 + with: + name: unit-tests-2-results + path: unit-tests-2-results + timeout-minutes: 2 + + - uses: actions/setup-node@v2 + with: { node-version: "${{ env.NODE_VERSION }}" } + timeout-minutes: 2 + + - name: merge coverage reports from different unit-tests jobs + run: npx cobertura-merge -o cobertura-coverage.xml package1=unit-tests-1-results/coverage/cobertura-coverage.xml package2=unit-tests-2-results/coverage/cobertura-coverage.xml + timeout-minutes: 1 + + - uses: actions/upload-artifact@v2 + with: + name: code-coverage + path: cobertura-coverage.xml + timeout-minutes: 2 + + - run: npx codecov -f cobertura-coverage.xml + timeout-minutes: 3 + lints: runs-on: ubuntu-20.04 env: { PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 } From 82767c300c3c5ea0d4d661689990c3af0069e95b Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 29 Apr 2022 16:21:59 -0400 Subject: [PATCH 08/13] Fix workflow job needs syntax --- .github/workflows/ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a2e9fa223c8..2029c95b3ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -106,9 +106,7 @@ jobs: timeout-minutes: 5 publish-code-coverage: - needs: - - 'unit-tests (1/2)' - - 'unit-tests (2/2)' + needs: unit-tests # This waits for *all* of the unit-tests jobs runs-on: ubuntu-20.04 steps: - uses: actions/download-artifact@v3 From 79ef91d96abfa483ce0f5639d9ea24c9fec8fed8 Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 29 Apr 2022 16:24:46 -0400 Subject: [PATCH 09/13] Drop max-old-space-size per Karans testing --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 886b00e6f39..b9504129152 100644 --- a/package.json +++ b/package.json @@ -69,9 +69,9 @@ "start:unified": "electron drop/electron/unified-dev/product/bundle/main.bundle.js", "start:unified:dev": "cross-env DEV_MODE=true yarnpkg start:unified", "start:unified:mock-adb": "cross-env ANDROID_HOME=drop/mock-adb yarnpkg start:unified", - "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' --max-old-space-size=16384 jest --projects src/tests/unit", + "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/unit", "publish-code-coverage": "npx codecov", - "test:e2e": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' --max-old-space-size=16384 jest --projects src/tests/end-to-end --runInBand --forceExit --detectOpenHandles", + "test:e2e": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/end-to-end --runInBand --forceExit --detectOpenHandles", "test:e2e:docker:build": "docker build -t accessibility-insights-e2e --target web .", "test:e2e:docker:build:web": "docker build -t accessibility-insights-web-e2e --target web .", "test:e2e:docker:build:unified": "docker build -t accessibility-insights-unified-e2e --target unified .", @@ -79,7 +79,7 @@ "test:e2e:docker:run:web": "docker run -t accessibility-insights-web-e2e", "test:e2e:docker:run:unified": "docker run -t accessibility-insights-unified-e2e sh -c \"yarn test:unified --ci\"", "test:e2e:docker": "npm-run-all --serial test:e2e:docker:build \"test:e2e:docker:run {@}\" --", - "test:unified": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' --max-old-space-size=16384 jest --projects src/tests/electron --runInBand --forceExit --detectOpenHandles", + "test:unified": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/electron --runInBand --forceExit --detectOpenHandles", "test:report:e2e": "lerna --scope accessibility-insights-report-e2e-tests run test", "unified-mac-sign": "node ./pipeline/scripts/unified-mac-sign.js", "watch": "npm-run-all --parallel --race --print-label watch:scss watch:grunt watch:test watch:webpack-dev-browser watch:webpack-unified", From c1da103bc842fa1de94b5089056c616ea04792a3 Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 29 Apr 2022 16:44:10 -0400 Subject: [PATCH 10/13] Try adding a checkout step --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2029c95b3ae..b7c5a11a87e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -109,6 +109,11 @@ jobs: needs: unit-tests # This waits for *all* of the unit-tests jobs runs-on: ubuntu-20.04 steps: + # This only needs to be present so codecov can use the source tree for some post-processing + # This job doesn't require that we install dependencies + - uses: actions/checkout@v2 + timeout-minutes: 2 + - uses: actions/download-artifact@v3 with: name: unit-tests-1-results From 2702c123a9b7c10acf98aa739d55d36526d2843a Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 29 Apr 2022 16:56:42 -0400 Subject: [PATCH 11/13] Try letting codecov do the merging --- .github/workflows/ci.yml | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b7c5a11a87e..902648ac8e6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -114,6 +114,10 @@ jobs: - uses: actions/checkout@v2 timeout-minutes: 2 + - uses: actions/setup-node@v2 + with: { node-version: "${{ env.NODE_VERSION }}" } + timeout-minutes: 2 + - uses: actions/download-artifact@v3 with: name: unit-tests-1-results @@ -126,21 +130,7 @@ jobs: path: unit-tests-2-results timeout-minutes: 2 - - uses: actions/setup-node@v2 - with: { node-version: "${{ env.NODE_VERSION }}" } - timeout-minutes: 2 - - - name: merge coverage reports from different unit-tests jobs - run: npx cobertura-merge -o cobertura-coverage.xml package1=unit-tests-1-results/coverage/cobertura-coverage.xml package2=unit-tests-2-results/coverage/cobertura-coverage.xml - timeout-minutes: 1 - - - uses: actions/upload-artifact@v2 - with: - name: code-coverage - path: cobertura-coverage.xml - timeout-minutes: 2 - - - run: npx codecov -f cobertura-coverage.xml + - run: yarn publish-code-coverage timeout-minutes: 3 lints: From 5128d7eef12766617a659659931a5eb9dd054b4e Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 29 Apr 2022 17:43:37 -0400 Subject: [PATCH 12/13] Add --no-compilation-cache --- package.json | 8 ++++---- packages/report-e2e-tests/package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index b9504129152..102273aa7c8 100644 --- a/package.json +++ b/package.json @@ -69,17 +69,17 @@ "start:unified": "electron drop/electron/unified-dev/product/bundle/main.bundle.js", "start:unified:dev": "cross-env DEV_MODE=true yarnpkg start:unified", "start:unified:mock-adb": "cross-env ANDROID_HOME=drop/mock-adb yarnpkg start:unified", - "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/unit", + "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --projects src/tests/unit", "publish-code-coverage": "npx codecov", - "test:e2e": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/end-to-end --runInBand --forceExit --detectOpenHandles", - "test:e2e:docker:build": "docker build -t accessibility-insights-e2e --target web .", + "test:e2e": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --projects src/tests/end-to-end --runInBand --forceExit --detectOpenHandles", + "test:e2e:docker:build": "docker build -t accessibility-insights-e2e --target web .", "test:e2e:docker:build:web": "docker build -t accessibility-insights-web-e2e --target web .", "test:e2e:docker:build:unified": "docker build -t accessibility-insights-unified-e2e --target unified .", "test:e2e:docker:run": "docker run -t accessibility-insights-e2e", "test:e2e:docker:run:web": "docker run -t accessibility-insights-web-e2e", "test:e2e:docker:run:unified": "docker run -t accessibility-insights-unified-e2e sh -c \"yarn test:unified --ci\"", "test:e2e:docker": "npm-run-all --serial test:e2e:docker:build \"test:e2e:docker:run {@}\" --", - "test:unified": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/electron --runInBand --forceExit --detectOpenHandles", + "test:unified": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --projects src/tests/electron --runInBand --forceExit --detectOpenHandles", "test:report:e2e": "lerna --scope accessibility-insights-report-e2e-tests run test", "unified-mac-sign": "node ./pipeline/scripts/unified-mac-sign.js", "watch": "npm-run-all --parallel --race --print-label watch:scss watch:grunt watch:test watch:webpack-dev-browser watch:webpack-unified", diff --git a/packages/report-e2e-tests/package.json b/packages/report-e2e-tests/package.json index 8d770e6c6f4..f8dceb448fb 100644 --- a/packages/report-e2e-tests/package.json +++ b/packages/report-e2e-tests/package.json @@ -6,7 +6,7 @@ "build": "tsc", "lint:check": "eslint --ext .ts ./", "lint:fix": "eslint --fix -c ../../.eslintrc.js --ext .ts ./", - "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --colors --runInBand" + "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --colors --runInBand" }, "repository": "git+https://github.com/microsoft/accessibility-insights-web.git", "author": "Microsoft", From b0c266ab883c5a17944fe2f6800ab841e5730feb Mon Sep 17 00:00:00 2001 From: Dan Bjorge Date: Fri, 29 Apr 2022 17:46:00 -0400 Subject: [PATCH 13/13] Revert "Add --no-compilation-cache" This reverts commit 5128d7eef12766617a659659931a5eb9dd054b4e. --- package.json | 8 ++++---- packages/report-e2e-tests/package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 102273aa7c8..b9504129152 100644 --- a/package.json +++ b/package.json @@ -69,17 +69,17 @@ "start:unified": "electron drop/electron/unified-dev/product/bundle/main.bundle.js", "start:unified:dev": "cross-env DEV_MODE=true yarnpkg start:unified", "start:unified:mock-adb": "cross-env ANDROID_HOME=drop/mock-adb yarnpkg start:unified", - "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --projects src/tests/unit", + "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/unit", "publish-code-coverage": "npx codecov", - "test:e2e": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --projects src/tests/end-to-end --runInBand --forceExit --detectOpenHandles", - "test:e2e:docker:build": "docker build -t accessibility-insights-e2e --target web .", + "test:e2e": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/end-to-end --runInBand --forceExit --detectOpenHandles", + "test:e2e:docker:build": "docker build -t accessibility-insights-e2e --target web .", "test:e2e:docker:build:web": "docker build -t accessibility-insights-web-e2e --target web .", "test:e2e:docker:build:unified": "docker build -t accessibility-insights-unified-e2e --target unified .", "test:e2e:docker:run": "docker run -t accessibility-insights-e2e", "test:e2e:docker:run:web": "docker run -t accessibility-insights-web-e2e", "test:e2e:docker:run:unified": "docker run -t accessibility-insights-unified-e2e sh -c \"yarn test:unified --ci\"", "test:e2e:docker": "npm-run-all --serial test:e2e:docker:build \"test:e2e:docker:run {@}\" --", - "test:unified": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --projects src/tests/electron --runInBand --forceExit --detectOpenHandles", + "test:unified": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --projects src/tests/electron --runInBand --forceExit --detectOpenHandles", "test:report:e2e": "lerna --scope accessibility-insights-report-e2e-tests run test", "unified-mac-sign": "node ./pipeline/scripts/unified-mac-sign.js", "watch": "npm-run-all --parallel --race --print-label watch:scss watch:grunt watch:test watch:webpack-dev-browser watch:webpack-unified", diff --git a/packages/report-e2e-tests/package.json b/packages/report-e2e-tests/package.json index f8dceb448fb..8d770e6c6f4 100644 --- a/packages/report-e2e-tests/package.json +++ b/packages/report-e2e-tests/package.json @@ -6,7 +6,7 @@ "build": "tsc", "lint:check": "eslint --ext .ts ./", "lint:fix": "eslint --fix -c ../../.eslintrc.js --ext .ts ./", - "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict --no-compilation-cache' jest --colors --runInBand" + "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest --colors --runInBand" }, "repository": "git+https://github.com/microsoft/accessibility-insights-web.git", "author": "Microsoft",