Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Martha~ to something like DrsResolver #392

Open
BMurri opened this issue Sep 8, 2023 · 0 comments
Open

Rename Martha~ to something like DrsResolver #392

BMurri opened this issue Sep 8, 2023 · 0 comments
Labels
Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security good first issue Good for newcomers TES Priority: P3 Groomed to a Priority 3 issue up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it
Milestone

Comments

@BMurri
Copy link
Contributor

BMurri commented Sep 8, 2023

Problem:
broadinstitute/cromwell-drs-localizer:develop is moving away from Martha. #391 changes the name of the environment variable used by TES, but it has been suggested that we also change the names in the configuration away from martha to something more generic and to remove the keyvault support.

Solution:
Rename Martha to DrsResolver (in options, configuration, etc.) and remove KeyVaultName and SecretName from MarthaOptions. Extend those changes throughout the deployment/configuration and TES->compute-node ecosystems.

Code dependencies

Will this require code changes in y/n
CoA, for new and/or existing deployments? yes
TES standalone, for new and/or existing deployments? yes
Terra, for new and/or existing deployments? yes
Build pipeline? no
Integration tests? no?
@BMurri BMurri added enhancement New feature or request up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it labels Sep 8, 2023
@BMurri BMurri added this to the TES Backlog milestone Sep 8, 2023
@ngambani ngambani added Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security and removed enhancement New feature or request labels Oct 5, 2023
@MattMcL4475 MattMcL4475 added the TES Priority: P3 Groomed to a Priority 3 issue label Dec 11, 2023
@BMurri BMurri added the good first issue Good for newcomers label Jan 19, 2024
@BMurri BMurri modified the milestones: TES Backlog, next Feb 14, 2025
@BMurri BMurri assigned BMurri and vsmalladi and unassigned BMurri Feb 14, 2025
@vsmalladi vsmalladi removed their assignment Mar 6, 2025
@vsmalladi vsmalladi modified the milestones: next, TES Backlog Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security good first issue Good for newcomers TES Priority: P3 Groomed to a Priority 3 issue up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it
Projects
None yet
Development

No branches or pull requests

4 participants