Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create factory method for TesTask creation #396

Open
MattMcL4475 opened this issue Sep 11, 2023 · 0 comments
Open

Create factory method for TesTask creation #396

MattMcL4475 opened this issue Sep 11, 2023 · 0 comments
Labels
Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security good first issue Good for newcomers TES Priority: P3 Groomed to a Priority 3 issue tobegroomed Add this label while creating new issues to get issues prioritized on the backlog up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it
Milestone
TES Backlog

Comments

@MattMcL4475
Copy link
Collaborator

MattMcL4475 commented Sep 11, 2023 •
edited
Loading

Currently, a TesTask is manually constructed in the CreateTaskAsync method in the controller, however it should be created from a factory method that sets the ID and the State. TBD what state should be default - probably "UNKNOWN", but test if this breaks any code paths first.

ga4gh-tes/src/TesApi.Web/Controllers/TaskServiceApi.cs

Line 164 in 5d6ce72

tesTask.Id = $"{tesTaskIdPrefix}{Guid.NewGuid():N}";

@MattMcL4475 MattMcL4475 added the enhancement New feature or request label Sep 11, 2023
@MattMcL4475 MattMcL4475 mentioned this issue Sep 11, 2023
Merged
@ngambani ngambani added Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security tobegroomed Add this label while creating new issues to get issues prioritized on the backlog and removed enhancement New feature or request labels Oct 5, 2023
@MattMcL4475 MattMcL4475 added the TES Priority: P3 Groomed to a Priority 3 issue label Dec 11, 2023
@BMurri BMurri added this to the TES Backlog milestone Feb 14, 2025
@BMurri BMurri added up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it good first issue Good for newcomers labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security good first issue Good for newcomers TES Priority: P3 Groomed to a Priority 3 issue tobegroomed Add this label while creating new issues to get issues prioritized on the backlog up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it
Projects
None yet
Milestone
TES Backlog
Development

No branches or pull requests
3 participants
@BMurri @MattMcL4475 @ngambani