Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser lookups don't handle instance names with extended characters #122

Closed
shueybubbles opened this issue Jun 29, 2023 · 0 comments
Closed

Browser lookups don't handle instance names with extended characters #122

shueybubbles opened this issue Jun 29, 2023 · 0 comments
Assignees
@shueybubbles
Milestone
Backlog

Comments

@shueybubbles
Copy link
Collaborator

If your SQL Server instance name has an extended character like TJUTVÅ the lookup will fail.
The driver doesn't convert the ASCII string correctly, it just converts the bytes to string.

2 Options:

  1. Fix the current code to convert the ASCII string containing escape codes to UTF8 correctly, or
  2. Change the lookup to use message 4 to get the port for the specific instance instead of getting instances for all messages. Properly encode the instance name to ASCII to make the request packet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shueybubbles shueybubbles

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@shueybubbles @grrlgeek