Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make windows bots green. #680

Closed
JoelEinbinder opened this issue Jan 27, 2020 · 4 comments
Closed

Make windows bots green. #680

JoelEinbinder opened this issue Jan 27, 2020 · 4 comments
Assignees

Comments

@JoelEinbinder
Copy link
Contributor

Blocking #678

Looks like some user-data-dir bugs and some line ending bugs in Chromium. Some failures to launch in firefox, and a webkit crash.

@JoelEinbinder
Copy link
Contributor Author

Status update:

Chromium is looking ok, with some behavior we should fix around cookies. #717

Firefox is looking ok.

WebKit for Windows is not looking ok. It has a lot of flakly tests, and I cannot get it to complete a full run.
Almost every test can crash. #797 should fix some of the crashes for worker tests, but there still appear to be more.
Almost every test can fail with a missing page.mainFrame(), #798
Everything that uses waitForLoadState can time out. A few random tests time out every run.
So far none of the problems have actually been Windows specific. They appear to be races that could happen on any platform, but appear most often on Windows due to its unique timings.

@pavelfeldman
Copy link
Member

Unhandled exception at 0x00007FFE3C85262B (vrfcore.dll) in MiniBrowser.exe: 0xC000041D: An unhandled exception was encountered during a user callback.

verifier.dll!AVrfpDphReportCorruptedBlock�()
verifier.dll!AVrfpDphCheckNormalFreeHeapBlock�()
verifier.dll!AVrfpDphRemoveEntry�()
verifier.dll!AVrfpDphRemoveFromDelayFree�()
verifier.dll!AVrfpDphPlaceOnDelayFree�()
verifier.dll!AVrfDebugPageHeapFree�()
ntdll.dll!RtlDebugFreeHeap�()
ntdll.dll!RtlpFreeHeap()
ntdll.dll!RtlpFreeHeapInternal()
ntdll.dll!RtlFreeHeap()
vrfcore.dll!VfCoreRtlFreeHeap(void *,unsigned long,void *)
vfbasics.dll!AVrfpRtlFreeHeap�()
ucrtbase.dll!_free_base()
cairo.dll!00007ffe097e2e1c()
cairo.dll!00007ffe098300b7()
WebKit2.dll!WebCore::BackingStoreBackendCairoImpl::`scalar deleting destructor'(unsigned int)
WebKit2.dll!WebKit::DrawingAreaProxyCoordinatedGraphics::`scalar deleting destructor'(unsigned int)
[Inline Frame] WebKit2.dll!std::default_delete<WebKit::DrawingAreaProxy>::operator()(WebKit::DrawingAreaProxy *) Line 1765
	at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\memory(1765)
[Inline Frame] WebKit2.dll!std::unique_ptr<WebKit::DrawingAreaProxy,std::default_delete<WebKit::DrawingAreaProxy>>::reset(WebKit::DrawingAreaProxy *) Line 1908
	at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\memory(1908)
[Inline Frame] WebKit2.dll!std::unique_ptr<WebKit::DrawingAreaProxy,std::default_delete<WebKit::DrawingAreaProxy>>::operator=(void *) Line 1813
	at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\memory(1813)
WebKit2.dll!WebKit::WebPageProxy::resetState(WebKit::WebPageProxy::ResetStateReason resetStateReason) Line 7487
	at C:\WebKit\Source\WebKit\UIProcess\WebPageProxy.cpp(7487)
WebKit2.dll!WebKit::WebPageProxy::close() Line 1088
	at C:\WebKit\Source\WebKit\UIProcess\WebPageProxy.cpp(1088)
[Inline Frame] WebKit2.dll!WebKit::WebView::close() Line 801
	at C:\WebKit\Source\WebKit\UIProcess\win\WebView.cpp(801)
WebKit2.dll!WebKit::WebView::wndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 119
	at C:\WebKit\Source\WebKit\UIProcess\win\WebView.cpp(119)
WebKit2.dll!WebKit::WebView::WebViewWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 94
	at C:\WebKit\Source\WebKit\UIProcess\win\WebView.cpp(94)
[External Code]
WebKit2.dll!WebCore::WindowMessageBroadcaster::SubclassedWndProc(HWND__ * hwnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 123
	at C:\WebKit\Source\WebCore\platform\win\WindowMessageBroadcaster.cpp(123)

@pavelfeldman
Copy link
Member

Screen Shot 2020-04-23 at 2 04 03 PM

@pavelfeldman
Copy link
Member

Hats off to @fujii for resolving this problem upstream!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants