Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An option to swallow the trailing CRLF on paste #5120

Closed
wasker opened this issue Mar 25, 2020 · 3 comments
Closed

An option to swallow the trailing CRLF on paste #5120

wasker opened this issue Mar 25, 2020 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal Backlog

Comments

@wasker
Copy link

wasker commented Mar 25, 2020

Description of the new feature/enhancement

Whenever I paste a line with a trailing CRLF in Terminal, it gets executed immediately. I'd like to have an option for Terminal to swallow the trailing CRLF, so it would be safe to paste text.

Proposed technical implementation details (optional)

I don't have any suggestions on implementation, but ConEmu has an option like that.
@wasker wasker added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 25, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 25, 2020
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Mar 25, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 25, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Mar 25, 2020
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Mar 25, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 26, 2020
@DHowett-MSFT
Copy link
Contributor

Yeah, we might as well have something like this. Somebody needs to suggest a config option (and whether it's profile-specific), and explain how it works when there's multiple newlines.

For reference, #395 is the holistic solution to this problem when all shells and applications eventually support it.

@zadjii-msft
Copy link
Member

You know, we also discussed this over in 9400 and have a proposed fix in #11473. To quoth:

just to trim the trailing newline if that's the only one in the paste contents. To quote: "It doesn't make sense to be warned for multiple lines, but copy a single line and try to paste it AND ONLY SEE ONE LINE IN THE DIALOG. That's dumb".

@wasker you think that'll work for you?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 9, 2021
@wasker
Copy link
Author

wasker commented Dec 9, 2021

@zadjii-msft Yeah, I think this is a decent resolution for this bug, thanks!

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 9, 2021
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal Backlog
Development

No branches or pull requests
3 participants
@wasker @DHowett-MSFT @zadjii-msft