Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usable-Command Palette]-Keyboard shortcuts are not included in the sub menu of New Tab list item. #7912

Closed
DasaradhaKamjula opened this issue Oct 13, 2020 · 4 comments
Labels
A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yUsable Accessibility tracking Area-CmdPal Command Palette issues and features Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. WindowsTerminal_Win32
Milestone

Comments

@DasaradhaKamjula
Copy link
Collaborator

DasaradhaKamjula commented Oct 13, 2020

User Experience:
Shortcuts that are provided inside dropdown for these submenu controls should be appended in sub menu too. Visual and screen reader user experience should be consistent through out the app .

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
Screen Reader: Narrator
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Search for New tab command in the search field
4.Navigate to New Tab list item having sub menu and activate it .
5.verify whether the shortcuts are appended with the list items in New tab are not.

Actual:
Keyboard shortcuts are not included in the sub menu of New Tab list item.

Expected:
Keyboard shortcuts should be included in the sub menu of New Tab list item like they are included in the drop down of windows terminal for the same list items.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc=%7B64DD7C5C-AA62-4D53-886E-BCAEE5341C01%7D&file=Guideline%20101%20Recommended%20Assistive%20Technology%20Tools%20for%20MAS%20Testing%20of%20Microsoft%20Digital%20Properties_v3.docx&action=default&mobileredirect=true

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 13, 2020
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Impact-Compliance It gotta be this way. labels Oct 13, 2020
@zadjii-msft
Copy link
Member

This is by design, the sub-commands of the "New tab..." command only have shortcut text if the user has a keybinding specifically for that action. Note that there's a difference between the actions specified by

{ "command": { "action": "newTab", "index": 0 }, "keys": "ctrl+shift+1" },

and

{ "command": { "action": "newTab", "profile": "profile0" }, "keys": "ctrl+shift+1" }

Even if "profile0" is the first profile the user has. If the user has the second action in their settings, the shortcut text will appear for the nested menu item:

image

@zadjii-msft zadjii-msft added Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 13, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 15, 2020
@cinnamon-msft cinnamon-msft added HCL-E+D Accessibility tracking Fixed Issues assigned by the accessibility team that have been fixed. labels Oct 20, 2020
@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@Chandresh1007 Chandresh1007 added A11yUsable Accessibility tracking HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Dec 7, 2020
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
@zadjii-msft
Copy link
Member

@Chandresh1007 @Priyanka-Chauhan123 @DasaradhaKamjula Since this is by design, can we close this issue?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 19, 2021
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Aug 23, 2021
@ghost
Copy link

ghost commented Aug 23, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@Priyanka-Chauhan123
Copy link
Collaborator

Agree with the above comments as the shortcuts are appearing for the nested menu items and closing this bug.

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Aug 24, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements labels Jun 23, 2022
@DHowett DHowett added the A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yUsable Accessibility tracking Area-CmdPal Command Palette issues and features Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. WindowsTerminal_Win32
Projects
None yet
Development

No branches or pull requests

6 participants