From 752b6e4e8a81872fb0359442c7a93e3b72fd9e87 Mon Sep 17 00:00:00 2001 From: Jackson Kearl Date: Thu, 29 Jul 2021 11:53:45 -0700 Subject: [PATCH] Fix #125506 --- .../browser/gettingStartedExtensionPoint.ts | 4 ++-- .../gettingStarted/browser/gettingStartedService.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedExtensionPoint.ts b/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedExtensionPoint.ts index aae5231afa933..2842fd4669089 100644 --- a/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedExtensionPoint.ts +++ b/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedExtensionPoint.ts @@ -159,12 +159,12 @@ export const walkthroughsExtensionPoint = ExtensionsRegistry.registerExtensionPo body: 'onContext:${2:key}' }, { - label: 'extensionInstalled', + label: 'onExtensionInstalled', description: localize('walkthroughs.steps.completionEvents.extensionInstalled', 'Check off step when an extension with the given id is installed. If the extension is already installed, the step will start off checked.'), body: 'extensionInstalled:${3:extensionId}' }, { - label: 'stepSelected', + label: 'onStepSelected', description: localize('walkthroughs.steps.completionEvents.stepSelected', 'Check off step as soon as it is selected.'), body: 'stepSelected' }, diff --git a/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedService.ts b/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedService.ts index cb262745c78fb..4b44b9b44cb66 100644 --- a/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedService.ts +++ b/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedService.ts @@ -609,14 +609,14 @@ export class GettingStartedService extends Disposable implements IGettingStarted } break; } - case 'stepSelected': - event = eventType + ':' + step.id; + case 'onStepSelected': case 'stepSelected': + event = 'stepSelected:' + step.id; break; case 'onCommand': event = eventType + ':' + argument.replace(/^toSide:/, ''); break; - case 'extensionInstalled': - event = eventType + ':' + argument.toLowerCase(); + case 'onExtensionInstalled': case 'extensionInstalled': + event = 'extensionInstalled:' + argument.toLowerCase(); break; default: console.error(`Unknown completionEvent ${event} when registering step ${step.id}`);