Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: yeoman generator for notebook #101319

Closed
2 tasks done
connor4312 opened this issue Jun 29, 2020 · 4 comments
Closed
2 tasks done

Test: yeoman generator for notebook #101319

connor4312 opened this issue Jun 29, 2020 · 4 comments

Comments

@connor4312
Copy link
Member

connor4312 commented Jun 29, 2020

Refs: #101056

Complexity: 2

Create Issue


Note: the starter was tested last endgame, this is sanity checking the generator code

  1. Grab the latest npm install -g yo generator-code
  2. Run INCLUDE_PROPOSED=1 yo code and select the notebook starter
  3. Fill out options. Check that it generates sane, runnable code for you.

If you use the test provider, you'll be able to see a sample notebook by creating an empty file with your chosen file extension (e.g. foo.my-cool-notebook).

@lszomoru
Copy link
Member

lszomoru commented Jun 30, 2020

@connor4312 has the latest version of generator-code been published to npm? I have installed the latest version (1.2.16) but that has been published 25 days ago, while the changes to the template were checked in 2 days ago.

@connor4312
Copy link
Member Author

@aeschli can you publish generator-code?

For running the test in the interim you can npm link the repo locally.

@aeschli
Copy link
Contributor

aeschli commented Jun 30, 2020

Published [email protected]

@weinand
Copy link
Contributor

weinand commented Jul 2, 2020

The correct name of the generator is "Notebook Renderer" not "notebook starter".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants