-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra characters appended when pasting text of certain size into Julia REPL running in VSCode #112831
Comments
Here are the logs from pasting
|
This happens for any string > 38 characters and < 44 characters |
happens for the same character counts even if I split the terminal / resize it |
It looks like the Julia REPL is not handling bracketed paste mode correctly and sending it back to print |
Thanks all for looking into it. I'll forward this over. |
@meganrogge Is the logging you did something I can enable locally? The extension dev isn't convinced it's something the extension is doing, and I'd like to be able to poke around at it. Also, is bracketed paste mode something that is handled by Windows, or by VS Code and passed through to the extension and then to the REPL/terminal? |
@BioTurboNick you can enable with the toggle escape sequence logging command, they then show up in devtool's console. Bracketed paste mode is enabled by the shell process sending us |
Thanks. The REPL when running in a normal Windows Terminal doesn't have the issue, which is what's odd. Something that stands out to me: the logging shows bracketed data is being sent, but then it's being parsed into two chunks. Where is that happening? (maybe that's a downstream by-design side effect of the bug, but I just want to thoroughly understand what's happening). Is the extension interposed into this process, and it should be stripping the brackets before the parse function is called using some hook? Or are the brackets unexpected at the "sending data" stage, and the extension is supposed to, but isn't, stripping them out prior to that? Is there a hook it should be using? |
@BioTurboNick WT doesn't support bracketed paste mode yet: microsoft/terminal#395
That should be fine
I don't think the extension has anything to do with this, it's just the repl executable. |
@Tyriar sorry one more question to gauge my understanding Is this what's happening?
|
Basically yeah, it's possible something funny is going on with conpty which is Windows' emulation layer if WT doesn't implements bracketed paste support. Hard to say exactly as I mainly only have experience programming on this side of the terminal. |
Out of curiosity, is there any way to interject some monitor of STDIN and STDOUT of the components here on Windows? Or to see which ones are hooked up to each other? |
On WSL it will be using a native pty backend where bracketed paste mode is supported. The more I think about this, the more I think this is blocked on Windows Terminal not supporting bracketed paste mode (microsoft/terminal#395). |
I only know how to log on the terminal end via the escape sequences command on Windows. |
Okay, thanks! I'll keep an eye on that being released. |
Steps to Reproduce:
Does this issue occur when all extensions are disabled?: Yes
The issue varies with length of the string, as documented here: julia-vscode/julia-vscode#1824
I'm reporting it here because this problem does not occur when the REPL is running inside a Windows Terminal window.
The text was updated successfully, but these errors were encountered: