Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when resizing side panel #134147

Closed
luabud opened this issue Sep 29, 2021 · 3 comments
Closed

Issues when resizing side panel #134147

luabud opened this issue Sep 29, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@luabud
Copy link
Member

luabud commented Sep 29, 2021

Testing #133919

I placed the output on the side panel, and once I resized it I noticed a "..." with an additional views option, even though only output is displayed there so no other view options are available. Also if you look at the GIF, once you resize it by dragging the line towards the right, the items on the right side of the menu disappear from the window, it doesn't seem there's a "boundary" defined.

sidepaneloutputbug

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues labels Sep 29, 2021
@sbatten sbatten added this to the On Deck milestone Sep 29, 2021
@sbatten sbatten closed this as completed in be75065 Oct 9, 2021
@sbatten sbatten modified the milestones: On Deck, September 2021 Oct 9, 2021
@sbatten
Copy link
Member

sbatten commented Oct 9, 2021

this bug would affect all composite bars along with a few other bugs I discovered while fixing. I made some improvements to the overall calculation that should squash them all and hopefully not introduce new ones. If you are verifying, this change will allow the active tab to be hidden into the overflow menu if the width is super small

@rzhao271 rzhao271 modified the milestones: September 2021, October 2021 Oct 26, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 26, 2021
@rzhao271
Copy link
Contributor

Going through the original steps, there's still a point after which dragging to the right results in the three icons to the right of the dropdown hiding from the sidebar.

@sbatten
Copy link
Member

sbatten commented Oct 26, 2021

@rzhao271 what you observed is expected when the number of action icons in the toolbar and the overflow icon are still too much for the minimum width because we don't have any overflow logic for the panel actions. i will leave this as verified as we have a separate issue for that.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@sbatten @rzhao271 @luabud and others