"Session contents restored…" date shown in US format

[krzysztofjeziorny]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.62.1
• OS Version: MacOS 11.6.1

Steps to Reproduce:

1. open the integrated terminal
2. quit VSCode
3. launch VSCode again
4. the "Session contents restored from" shows the date in US format ("11/5/2021 at 1:10:47 PM") ignoring the OS's region settings (Austria in my case, with UK English set as user's language)
5. changing the user's language (i.e. to German to reflect the region) doesn't fix the format, just changes the language of the message ("Sitzungsinhalte aus 11/10/2021 um 1:26:09 PM wiederhergestellt")

[stacklast]

I have the same Issue:

• Windows 11 Home
  • Version: 21H2
  • Compilation: 22000.318
• VS Code Version: 1.62.1

The same steps to reproduce.

[Tyriar]

Hmm this is actually already using locale to string, I guess that means Electron's locale isn't set based on the system 🤔

vscode/src/vs/platform/terminal/node/ptyService.ts

Line 140 in 950e89b

}, "Session contents restored from {0} at {1}", new Date(state.timestamp).toLocaleDateString(), new Date(state.timestamp).toLocaleTimeString());

[Tyriar]

This is working fine for me on Windows:

[Tyriar]

I can reproduce on macOS despite having Australia set in Region and "locale": "en-gb" in runtime arguments. @deepak1556 @TylerLeonhardt any idea why Date.toLocaleDateString isn't respecting the locale on mac?

[deepak1556]

@Tyriar this issue might have the same root cause as #85675, locale being broken in ELECTRON_RUN_AS_NODE processes.

[Tyriar]

@deepak1556 ah ok this makes sense as the date is formatted on the pty host. We might be able to format the date on the renderer to work around this.

[Tyriar]

Actually, let's pass the locale over from the renderer process when reviving processes:

vscode/src/vs/platform/terminal/node/ptyService.ts

Lines 125 to 141 in cd66eec

	async reviveTerminalProcesses(state: string) {
	const parsedUnknown = JSON.parse(state);
	if (!('version' in parsedUnknown) || !('state' in parsedUnknown) || !Array.isArray(parsedUnknown.state)) {
	this._logService.warn('Could not revive serialized processes, wrong format', parsedUnknown);
	return;
	}
	const parsedCrossVersion = parsedUnknown as ICrossVersionSerializedTerminalState;
	if (parsedCrossVersion.version !== 1) {
	this._logService.warn(`Could not revive serialized processes, wrong version "${parsedCrossVersion.version}"`, parsedCrossVersion);
	return;
	}
	const parsed = parsedCrossVersion.state as ISerializedTerminalState[];
	for (const state of parsed) {
	const restoreMessage = localize({
	key: 'terminal-session-restore',
	comment: ['date the snapshot was taken', 'time the snapshot was taken']
	}, "Session contents restored from {0} at {1}", new Date(state.timestamp).toLocaleDateString(), new Date(state.timestamp).toLocaleTimeString());

[JacksonKearl]

verified, only the most recent message has "hot swapping", but I think that's roughly expected.

[Tyriar]

Yep after it's written to the terminal it's fixed text and won't change just like the rest of the buffer