Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go To Source Definition UX improvements #152252

Open
andrewbranch opened this issue Jun 15, 2022 · 2 comments
Open

Go To Source Definition UX improvements #152252

andrewbranch opened this issue Jun 15, 2022 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues ux User experience issues
Milestone

Comments

@andrewbranch
Copy link
Member

Following up on TypeScript’s new Go To Source Definition command (d851ea5), I want to track some editor-side UX improvements:

  • Can we replace the error notification for “no source definitions found” with an inline message similar to Go To Definition?

    image
  • Can we somehow indicate when a result is a guess? This is already returned in the protocol response via an unverified property, but it is never surfaced to the user. When multiple locations are returned, maybe we could add something to the peek locations UI:

    image

    (Note: the unverified flag is also sometimes set in normal Go To Definition responses, so this request is not specific to Go To Source Definition.)

    When only one location is returned, maybe a notification would suffice, but I would love design input on this.

@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues ux User experience issues labels Jun 15, 2022
@mjbvz mjbvz added this to the June 2022 milestone Jun 15, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 21, 2022

@jrieken Any thoughts on these? I think we'd have to implement these in core

@jrieken
Copy link
Member

jrieken commented Jun 22, 2022

Can we somehow indicate when a result is a guess? This is already returned in the protocol response via an unverified property, but it is never surfaced to the user.

There is currently no way to express that but it reminds me of #74237 which is about adding a kind-property to references/locations. That would allow us to classify/filter/etc...

Can we replace the error notification for “no source definitions found” with an inline message similar to Go To Definition?

No sure how "go to source" is implemented but in case it is using the editor.action.goToLocations-command than a "no-results-message" can be passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants