Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More info section is illegible after switching to RTL language and back #167871

Closed
lramos15 opened this issue Dec 1, 2022 · 6 comments
Closed
Assignees
Labels
chromium Issues and items related to Chromium confirmation-pending electron-19-update upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@lramos15
Copy link
Member

lramos15 commented Dec 1, 2022

  1. Set your device to an RTL language such as arabic
  2. Set your device back to LTR language such as english
  3. 🐛 The more info section become illegible.
    A reboot seems to fix this.

image

@lramos15 lramos15 changed the title Wrapping makes marketplace more info section illegible More info section is illegible after switching to RTL language and back Dec 1, 2022
@sandy081 sandy081 assigned deepak1556 and unassigned sandy081 Dec 2, 2022
@sandy081
Copy link
Member

sandy081 commented Dec 2, 2022

Seems like an electron/chromium issue, because I am using the underneath JS Date library to get the string format

$('div', undefined, new Date(gallery.releaseDate).toLocaleString(locale, { hourCycle: 'h23' }))

@deepak1556 deepak1556 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) chromium Issues and items related to Chromium confirmation-pending electron-19-update labels Dec 6, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Dec 9, 2022

Which OS is this on, and did you restart the device in between?
I actually saw a similar issue recently with the Windows 11 start menu.

@lramos15
Copy link
Member Author

lramos15 commented Dec 9, 2022

Which OS is this on, and did you restart the device in between? I actually saw a similar issue recently with the Windows 11 start menu.

Mac, didn't restart the device. Restarting the device appears to fix the issue

@rzhao271
Copy link
Contributor

Merging to #169114

@deepak1556
Copy link
Collaborator

@rzhao271 is this merged into #169114 because the more info section also does not require the system locale and reverting it to using application locale is the preferred fix ?

@rzhao271
Copy link
Contributor

@TylerLeonhardt and I were discussing whether that section should even be using the system locale, and I am using #169114 as a catch-all issue for that.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chromium Issues and items related to Chromium confirmation-pending electron-19-update upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants