Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.action.focusNextCursor doesn't reveal the primary cursor #182147

Closed
akbyrd opened this issue May 11, 2023 · 1 comment · Fixed by #182148
Closed

editor.action.focusNextCursor doesn't reveal the primary cursor #182147

akbyrd opened this issue May 11, 2023 · 1 comment · Fixed by #182148
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@akbyrd
Copy link
Contributor

akbyrd commented May 11, 2023

Type: Bug

editor.action.focusNextCursor and editor.action.focusPreviousCursor do not reveal the primary cursor.

Steps to Repro:

  • Create multiple cursors that don't all fit on the screen at once
  • Execute editor.action.focusNextCursor
  • Notice the editor never scrolls to review a new cursor, indicating the primary cursor is not being revealed

In this gif I've added color to the primary cursor. You can see the primary cursor change both by the color of the cursors both in the editor and the overview ruler. As the primary cursor changes the view does not update to reveal it.

Focus Next Cursor Broken

To maximize the usefulness of this command it's helpful if it ensures the primary cursor is visible when it changes. This dovetails nicely with #85630 which has an open PR.

VS Code version: Code - Insiders 1.79.0-insider (d0ca613, 2023-05-10T16:05:20.769Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs AMD Ryzen 9 5950X 16-Core Processor (32 x 3400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.92GB (15.32GB free)
Process Argv --crash-reporter-id 22cf4e37-a96e-4ad9-82f0-8715f8e2bf6e
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
pyind779:30611226
pythonsymbol12:30651887
2i9eh265:30646982
showlangstatbar:30737417
azdwalk:30721579
pythonms35:30671666
j16hj152:30680472
ecj1e332:30687743
pythonfmttext:30716741
pythoncmvfstr:30726892
fixshowwlkth:30724385
showsbindicator:30724477
pythongtdpath:30726887

@akbyrd
Copy link
Contributor Author

akbyrd commented May 18, 2023

I have a PR available for this: #182148

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Mar 20, 2024
@alexdima alexdima added this to the March 2024 milestone Mar 20, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 20, 2024
@mjbvz mjbvz added the verified Verification succeeded label Mar 25, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
4 participants