New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env.onDidChangeShell API naming feedback #194097

Closed

lszomoru opened this issue Sep 26, 2023 · 1 comment

Assignees

Labels

*as-designed under-discussion

Member

lszomoru commented Sep 26, 2023

Testing #194028

Most probably it's too late for this but I did notice some inconsistencies where both "shell" and "profile" are being used:

The even is called "onDidChangeShell"
The field tied to the event is called "shell"
The command in VS Code that results in the event being fired is called "Select Default Profile"
There is already existing API to register a profile provider - registerTerminalProfileProvider

It would be nice if we would settle on one of them and use it consistently across the API surface

lszomoru assigned Tyriar

Member

Tyriar commented Sep 26, 2023

These are different concepts though; a profile is a combination of a name, executable, arguments, env, icon, etc. and a shell is just the executable.

Tyriar added the under-discussion label

Tyriar added the *as-designed label

Tyriar closed this as completed

vs-code-engineering bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.