Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pwsh suggest doesn't hide when completing using pwsh's own ghost text completion #210396

Closed
Tyriar opened this issue Apr 15, 2024 · 2 comments
Closed

Pwsh suggest doesn't hide when completing using pwsh's own ghost text completion #210396

Tyriar opened this issue Apr 15, 2024 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 15, 2024 •
edited
Loading

Testing: #210394, #154662

Recording 2024-04-15 at 07 49 21 (1)

cc @cpendery
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Apr 15, 2024
@Tyriar Tyriar added this to the April 2024 milestone Apr 15, 2024
@Tyriar Tyriar self-assigned this Apr 15, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Apr 17, 2024

This isn't so easy to fix. I think we need a better model for fetching the current command line, basically what TextAreaSyncAddon does but more generic and shared.

@Tyriar Tyriar modified the milestones: April 2024, Backlog Apr 17, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Dec 9, 2024

This actually works pretty well now, it will not hide it but it will show exact matches which is arguably the correct behavior:

Image

@Tyriar Tyriar closed this as completed Dec 9, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@Tyriar