Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSLT Emmet stopped working #30496

Closed
crewone opened this issue Jul 12, 2017 · 4 comments
Closed

XSLT Emmet stopped working #30496

crewone opened this issue Jul 12, 2017 · 4 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
July 2017

Comments

@crewone
Copy link

crewone commented Jul 12, 2017 •
edited
Loading

  • VSCode Version: Insiders 1.15.0-insider
  • OS Version: Windows 10

Steps to Reproduce:

  1. Make an XSL file with a basic XML structure
  2. Type 'wh' + tab, it incorrectly expands to '<wh></wh>'
  3. Set "emmet.useNewEmmet":false in preferences
  4. Type 'wh' + tab in the XSL file... it expands (correctly) to: '<xsl:when test=""></xsl:when>'

Same for other xsl emmet extensions.

'if' expands to '<if>', but should expand to '<xsl:if test=""></xsl:if>'
@vscodebot vscodebot bot added the insiders label Jul 12, 2017
@vscodebot vscodebot bot added the emmet Emmet related issues label Jul 12, 2017
@ramya-rao-a ramya-rao-a added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 19, 2017
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 19, 2017 •
edited
Loading

@sergeche I believe this is because xsl snippets are not present in https://github.com/emmetio/snippets

What are your plans to support xml in Emmet 2.0?

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jul 19, 2017
@sergeche
Copy link

Yes, these snippets are missing now, will add them

@ramya-rao-a ramya-rao-a mentioned this issue Jul 19, 2017
Closed
@ramya-rao-a
Copy link
Contributor

Thanks @sergeche

I created emmetio/atom-plugin#30 to track this, since you are using that repo for tracking general issues

@ramya-rao-a
Copy link
Contributor

Created PR emmetio/snippets#1 to fix this upstream

@ramya-rao-a ramya-rao-a added this to the July 2017 milestone Jul 23, 2017
@roblourens roblourens added the verified Verification succeeded label Aug 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
4 participants
@sergeche @roblourens @crewone @ramya-rao-a