Sorting/ranking of code actions

[Tyriar]

If available, it will probably be the most useful.

[mjbvz]

@jrieken Adding you since I believe this would require an API change to code actions to add a sort order or similar

[jrieken]

add a sort order or similar

And how do you do that given there is multiple providers that only have a local view of the world? I am open for ideas but it is tricky. From the tslint's POV inserting the missing semicolon is key, from typescript's POV inserting the import is key.

[mjbvz]

I'm not sure we can create a general solution. A few ideas on how some sort of ordering could be introduced though:

• Sort of error severity.

  If code actions had additional metadata about which error they fixed, sort so that fixes for errors are shown before fixes for warnings. We could also use the error info to group fixes by error, or use this info to show error information like VS does in its quick fix menu

• Sort by fixed error range.

  One idea would be to show actions that fix errors that span larger ranges. Not sure if this would be useful

• Create types of quick fixes, similar to intellij. Show quick fixes before other actions like refactorings

• Show actions that fix the problem higher than actions that suppress the problem. This also would require some additional metadata on the code action, similar to quick fix types.

[jrieken]

Yes, it all requires enhanced API, I like the code-action-diagnostics-association, tho things need to be thought out carefully as there are also other requests in this area, like expressing a code action as text edit(s) and not just as command

[jrieken]

Closing this as a dupe of #38623 and #34664 which makes code actions know the errors they fix. We will use that as sorting/grouping hint