Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path intellisence not working with paths aliases #41458

Closed
Ristaaf opened this issue Jan 11, 2018 · 7 comments
Closed

Path intellisence not working with paths aliases #41458

Ristaaf opened this issue Jan 11, 2018 · 7 comments
Assignees
Labels
javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Ristaaf
Copy link

Ristaaf commented Jan 11, 2018

  • VSCode Version: 1.19.1
  • OS Version: Windows 10 Fall Creators Update

Steps to Reproduce:

  1. Create a paths alias in the tsconfig.json as this: "paths": { "@myapp/*": ["app/*"] }
  2. Try to import from the alias triggering intellisence after writing import {} from "@myapp/ This will not show any folders under app, so the path intellisence does not work at all in this use case!

Does this issue occur when all extensions are disabled?: Yes

@mjbvz mjbvz self-assigned this Jan 11, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 11, 2018
@mjbvz mjbvz added this to the January 2018 milestone Jan 11, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 11, 2018

Tracked upstream by microsoft/TypeScript#19113

Should be fixed by TS 2.7

@mjbvz mjbvz closed this as completed Jan 11, 2018
@mjbvz mjbvz added javascript JavaScript support issues verification-needed Verification of issue is requested labels Jan 11, 2018
@octref
Copy link
Contributor

octref commented Feb 1, 2018

@mjbvz Is this supposed to be fixed? Does not seem to be working for me.

@octref
Copy link
Contributor

octref commented Feb 1, 2018

Tested together with @mjbvz. If you have a baseUrl it should work. However, the path completions items are not having the correct CompletionItemKind.

@ramya-rao-a
Copy link
Contributor

@mjbvz How do you want to handle this? Push it to Feb for the right CompletionKind or mark it as verfied?

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 2, 2018

I’ll open another bug for the kind. I’d say the main feature is verified

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Feb 2, 2018
@ramya-rao-a
Copy link
Contributor

Thanks @mjbvz
Added the verified label

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 2, 2018

Opened microsoft/TypeScript#21582 to track the kind issue upstream

Will be opening a few more upstream bugs around compilerOptions.paths path completions as well

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants