Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin extension in installed extensions directory #46453

Closed
roblourens opened this issue Mar 24, 2018 · 2 comments
Closed

Builtin extension in installed extensions directory #46453

roblourens opened this issue Mar 24, 2018 · 2 comments
Assignees
Labels
extensions Issues concerning extensions

Comments

@roblourens
Copy link
Member

Some time ago, @mjbvz and I both saw old versions of the node2 extension installed next to marketplace extensions on our machines.

Investigating #45657 (via email), we found that @lostfields had the same issue.

I don't know how it's possible for this to happen without explicitly installing node2 via a vsix or something else unusual.

@sandy081 can you point me towards the code that should skip builtin extensions when autoupdating extensions? Is it possible that it could install node2 from the marketplace when it shouldn't?

@roblourens roblourens added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 24, 2018
@roblourens roblourens self-assigned this Mar 24, 2018
@roblourens roblourens added the extensions Issues concerning extensions label Mar 24, 2018
@sandy081
Copy link
Member

@roblourens Here is the code that triggers auto update.

But, we only auto update extensions from user extensions folder and not those coming from internal extensions folder.

@roblourens
Copy link
Member Author

🤷‍♂️

@roblourens roblourens removed the under-discussion Issue is under discussion for relevance, priority, approach label Sep 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

2 participants