Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js debugger adapter crashes with TypeError about 'url' of undefined #52369

Closed
dramforever opened this issue Jun 20, 2018 · 3 comments
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@dramforever
Copy link

Issue Type: Bug

This crash occurs on both 1.25.0-insider and 1.24.1.

Steps to reproduce:

Put this file into vscbug.js

function fc(fn) {
    return new Promise((resolve, _reject) =>
        setImmediate(() => resolve(fn())));
}

fc(parseInt).then(console.log);

And hit F5 to start debugging.

Expected

Debugging runs normally to completion, with output:

NaN

Actual

The debugger adapter crashes. This is shown in the debugging tab:

D:\Program Files\nodejs\node.exe --inspect-brk=17564 vscbug.js 
Debugger listening on ws://127.0.0.1:17564/88a53b9b-7fe0-4b9e-8436-adb5261d61de

******** Unhandled error in debug adapter: TypeError: Cannot read property 'url' of undefined
    at isLogpointMessage (c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\ms-vscode.node-debug2\node_modules\vscode-chrome-debug-core\out\src\chrome\internalSourceBreakpoint.js:25:55)
    at Object.stackTraceWithoutLogpointFrame (c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\ms-vscode.node-debug2\node_modules\vscode-chrome-debug-core\out\src\chrome\internalSourceBreakpoint.js:28:9)
    at NodeDebugAdapter.onConsoleAPICalled (c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\ms-vscode.node-debug2\node_modules\vscode-chrome-debug-core\out\src\chrome\chromeDebugAdapter.js:983:50)
    at NodeDebugAdapter.onConsoleAPICalled (c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\ms-vscode.node-debug2\out\src\nodeDebugAdapter.js:382:19)
    at Client.chrome.Runtime.on.params (c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\ms-vscode.node-debug2\node_modules\vscode-chrome-debug-core\out\src\chrome\chromeDebugAdapter.js:317:67)
    at emitOne (events.js:116:13)
    at Client.emit (events.js:211:7)
    at Client.processMessage (c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\ms-vscode.node-debug2\node_modules\noice-json-rpc\lib\noice-json-rpc.js:78:18)
    at LoggingSocket.Client.socket.on (c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\ms-vscode.node-de[...]

VS Code version: Code - Insiders 1.25.0-insider (b4a18da, 2018-06-19T07:49:07.900Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2904)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 7.85GB (2.98GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 0%
Extensions: none
@weinand weinand assigned isidorn and roblourens and unassigned weinand and isidorn Jun 20, 2018
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 20, 2018
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jun 20, 2018
@roblourens roblourens added this to the June 2018 milestone Jun 20, 2018
@roblourens
Copy link
Member

I believe this is the same as microsoft/vscode-chrome-debug-core#334 which is fixed in the next Insiders.

@roblourens roblourens removed this from the June 2018 milestone Jun 21, 2018
@roblourens roblourens added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Jun 21, 2018
@dramforever
Copy link
Author

Okay, thanks

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants