Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UX: tab key does not properly switch focus #52467

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 20, 2018 · 11 comments
Closed

Settings UX: tab key does not properly switch focus #52467

AccessibilityTestingTeam-TCS opened this issue Jun 20, 2018 · 11 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues macos Issues with VS Code on MAC/OS X settings-editor VS Code settings editor issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.1
OS Version : HighSierra10.13.5

Additional Details:
MAS Violated : MAS 2.4.3

Repro Steps:

  1. Launch VS Code while VoiceOver is ON.
  2. Navigate to Settings icon in Activity Bar->Press Enter->Select "Settings" from dropdown.
  3. Focus order is not proper when navigating through all the lists,list items,buttons,links present on the screen while navigating using "Tab" key and also Shift Tab key.

Actual:
Keyboard focus order is not properly aligned when navigating through the list items present on the page using Shift Tab key and Tab key

When Tab key is pressed the focus order shifts from downward to upwards which is not the ideal functionality of the Tab key.

When Shift Tab key is pressed the focus order shifts from upwards to downward which is not the ideal functionality of the Shift Tab key.

Expected:
Keyboard focus order is should be properly aligned when navigating through the list items present on the page using Shift Tab key and Tab key

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
The user will not be able to get clarity about focus order alignment and movement when using Tab or Shift Tab key.

MAS Reference:
MAS 2.4.3 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={0de7fbe1-ad7e-48e5-bcbb-8d986691e2b9}

Attachment For Reference:
A11y_VSCode_UserSettings_Keyboard_FocusOrder.pptx

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Jun 20, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@chrmarti chrmarti added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels Jun 21, 2018
@sandy081 sandy081 added this to the July 2018 milestone Jun 25, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_UserSettings_Keyboard: Keyboard focus order is not properly aligned when navigating through the list items present on the page using Shift Tab key and Tab key i.e.(Commonly Used,Editor,Workbench………..etc) Settings UX: tab key does not properly switch focus Jul 4, 2018
@isidorn isidorn assigned roblourens and unassigned sandy081 Jul 4, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

This is the new settings ux, assigning to @roblourens
Feels like all those items needs to have proper tabindexes. Leaving for july - not sure when the settings ux goes out of preview since that is the time we should address this issues.

@roblourens
Copy link
Member

You say "focus order is not right", can you be more specific about what the problem is?

@isidorn isidorn added the info-needed Issue requires more information from poster label Jul 17, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 17, 2018

@roblourens I think the focus is not jumping properly from left to right and from up to down. If I press tab a couple of times in the new settings ux the behavior is unexpected for me
Though @AccessibilityTestingTeam-TCS can explain what he exactly meant

@roblourens roblourens removed the info-needed Issue requires more information from poster label Jul 17, 2018
@roblourens
Copy link
Member

This is not the new settings editor, this is basically the same as #52468

@roblourens
Copy link
Member

@isidorn you can weigh in on #54039 if you want

@isidorn
Copy link
Contributor

isidorn commented Jul 18, 2018

@roblourens this is the new settings editor - it is quite clear if you look at the attachment.
Yes, let's treat all new settings editor focus jumping issues as part of #54039

@isidorn isidorn closed this as completed Jul 18, 2018
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 18, 2018
@roblourens
Copy link
Member

Are we looking at the same attachment? I see the old editor.

@roblourens roblourens reopened this Jul 18, 2018
@roblourens roblourens removed the *duplicate Issue identified as a duplicate of another issue(s) label Jul 18, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 18, 2018

My appologies, it is the old settings editor.

@roblourens roblourens modified the milestones: July 2018, August 2018 Aug 2, 2018
@roblourens
Copy link
Member

The old editor is going away, and is no longer the default settings editor, and I'm not sure how to fix this...

@isidorn
Copy link
Contributor

isidorn commented Aug 29, 2018

@roblourens if I were you I would put this to the backlog. Since we now have the new settings experience

@roblourens roblourens removed this from the September 2018 milestone Aug 29, 2018
@roblourens roblourens added this to the Backlog milestone Aug 29, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 16, 2018
@isidorn isidorn added macos Issues with VS Code on MAC/OS X windows VS Code on Windows issues and removed windows VS Code on Windows issues labels Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues macos Issues with VS Code on MAC/OS X settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

5 participants