Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal search skips some entries while searching upwards #73459

Closed
Yanpas opened this issue May 8, 2019 · 1 comment · Fixed by #73599
Closed

Terminal search skips some entries while searching upwards #73459

Yanpas opened this issue May 8, 2019 · 1 comment · Fixed by #73599
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
May 2019

Comments

@Yanpas
Copy link
Contributor

Yanpas commented May 8, 2019 •
edited
Loading

  • VSCode Version: 1.33.1
  • OS Version: linux

Steps to Reproduce:

  1. Open a terminal on the right side (about 80 chars wide)
  2. cat attached file LOG2.txt
  3. Press search and enter error to the searchbar, search upwards (shift + enter)
  4. line 373 e.g. got skipped, check with grep -i error

Does this issue occur when all extensions are disabled?: Yes/No
@vscodebot vscodebot bot added the search Search widget and operation issues label May 8, 2019
@roblourens roblourens assigned Tyriar and unassigned roblourens May 8, 2019
@roblourens roblourens removed the search Search widget and operation issues label May 8, 2019
@Tyriar
Copy link
Member

Tyriar commented May 10, 2019

I believe this will be fixed when we update xterm.js, there were 2 recent fixes to search xtermjs/xterm.js#1866 and xtermjs/xterm.js#2025

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 10, 2019
@Tyriar Tyriar added this to the May 2019 milestone May 10, 2019
@Tyriar Tyriar mentioned this issue May 13, 2019
Merged
10 tasks
@lramos15 lramos15 added the verified Verification succeeded label May 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
May 2019
Development

Successfully merging a pull request may close this issue.

Update vscode-xterm microsoft/vscode
4 participants
@roblourens @Tyriar @lramos15 @Yanpas