Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickPick button icons aren't showing in latest insiders #81142

Closed
eamodio opened this issue Sep 19, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7356
Closed

QuickPick button icons aren't showing in latest insiders #81142

eamodio opened this issue Sep 19, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7356
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
September 2019

Comments

@eamodio
Copy link
Contributor

eamodio commented Sep 19, 2019

Issue Type: Bug

In the latest insiders none of my QuickPick button icons are showing up. It is also affecting the built-in Back arrow as well.

/cc @chrmarti

VS Code version: Code - Insiders 1.39.0-insider (8b6e0ef, 2019-09-19T03:15:21.720Z)
OS version: Windows_NT x64 10.0.18980

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.93GB (17.82GB free)
Process Argv
Screen Reader no
VM 0%
@eamodio
Copy link
Contributor Author

eamodio commented Sep 19, 2019

Not sure if it is related to this or not: #81111 (comment)

@chrmarti
Copy link
Collaborator

Looks like QuickInput needs to update icon class to codicon. Investigating...

@chrmarti chrmarti added this to the September 2019 milestone Sep 19, 2019
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Sep 19, 2019
@bpasero
Copy link
Member

bpasero commented Sep 19, 2019

cc @misolori

@miguelsolorio
Copy link
Contributor

Thanks for fixing @chrmarti!

@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Sep 19, 2019
@ejizba ejizba mentioned this issue Sep 19, 2019
Closed
@anthonydresser anthonydresser mentioned this issue Sep 25, 2019
Merged
@mjbvz mjbvz added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 817eb6b0c720a4ecbc13c020afbbebfed667aa09 microsoft/azuredatastudio
5 participants
@eamodio @bpasero @chrmarti @mjbvz @miguelsolorio