Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple account management from settings sync #94050

Closed
aeschli opened this issue Mar 31, 2020 · 1 comment
Closed

Decouple account management from settings sync #94050

aeschli opened this issue Mar 31, 2020 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) settings-sync

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 31, 2020

Testing #93811

By playing around with the new account management feature I logged in to two Microsoft accounts and a Github account:
image

This looks really cool! So the idea is that this becomes a centralized place for managing the accounts I'm signed-in, correct? '

Settings sync would just one client of this, using one of the accounts. However, currently, settings sync seems to be more than just a regular client

  • it pops up automatically when I logged in to a new account and ask to start settings sync. It shouldn't do that, maybe I just add an account for some other purpose.
  • when I stop settings sync, it logs out from the account. It should prompt me before doing that. Maybe I want stay logged in for another feature.
  • when turning on settings sync, it only proposes one of the accounts I've been logged in
    image
    I would expect to also see my other account there. 'Use another account' brings me to a Microsoft web page like when creating a new account.

Feel free to close the issue if I misinterpreted the feature.

@sandy081
Copy link
Member

sandy081 commented Apr 9, 2020

/duplicate

#94766

@sandy081 sandy081 removed this from the April 2020 milestone Apr 9, 2020
@sandy081 sandy081 closed this as completed Apr 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) settings-sync
Projects
None yet
Development

No branches or pull requests

4 participants
@RMacfarlane @aeschli @sandy081 and others