Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX for an empty notebook #95903

Closed
roblourens opened this issue Apr 22, 2020 · 2 comments
Closed

UX for an empty notebook #95903

roblourens opened this issue Apr 22, 2020 · 2 comments
Assignees
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach

Comments

@roblourens
Copy link
Member

We prevent the user from emptying a notebook - if the last cell is deleted, we insert a new empty cell. But a notebook provider can still cause an empty cell to be created either by resolving a notebook to have no cells or deleting cells programmatically.

We could

  • Make this an error, say notebooks have to return at least one cell
  • Insert an empty cell, which would make the document dirty upon opening
  • Show some nice UX which explains that the notebook is empty and has buttons to insert a cell
@roblourens roblourens added notebook under-discussion Issue is under discussion for relevance, priority, approach labels Apr 22, 2020
@rebornix
Copy link
Member

Me personally prefer the last one

Show some nice UX which explains that the notebook is empty and has buttons to insert a cell

It's weird to me that you can't have an empty notebook. Users might delete all cells to get a clean state to restart the work while showing errors or inserting empty cells immediately seems like the editor tries to fight back.

@roblourens
Copy link
Member Author

@rebornix added a toolbar when it's empty, I think this is enough

@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants