Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet kicks in when editing pure xml documents #97632

Closed
fbricon opened this issue May 12, 2020 · 3 comments
Closed

Emmet kicks in when editing pure xml documents #97632

fbricon opened this issue May 12, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented May 12, 2020

  • VSCode Version: 1.45.0 and 1.46.0-insiders
  • OS Version: macOS Catalina 10.15.4

Steps to Reproduce:

  1. Create an xml document. containing
<a>

</a>
  1. Within the <a> tag, start typing a, emmet proposes a *ton of snippets.

Screen Shot 2020-05-12 at 7 52 19 PM

Emmet should not contribute to xml completion with unrelated HTML bloat.

Does this issue occur when all extensions are disabled?: Yes

@alexdima alexdima added the emmet Emmet related issues label May 12, 2020
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug emmet-revamp and removed emmet-revamp labels Oct 22, 2020
@rzhao271 rzhao271 added this to the Backlog milestone Nov 4, 2020
@rzhao271 rzhao271 modified the milestones: Backlog, November 2020 Nov 16, 2020
@rzhao271 rzhao271 modified the milestones: January 2021, On Deck Jan 6, 2021
@rzhao271 rzhao271 added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors hackathon Label reserved for specific events labels Feb 1, 2021
@rzhao271 rzhao271 modified the milestones: On Deck, Backlog Feb 12, 2021
@iamkacperwasik
Copy link

iamkacperwasik commented Feb 24, 2021

As the docs says:

Emmet abbreviation and snippet expansions are enabled by default in html, haml, pug, slim, jsx, xml, xsl, css, scss, sass, less and stylus files, as well as any language that inherits from any of the above like handlebars and php.

Read here for more info.

You can disable emmet for xml in settings.json like so

"emmet.excludeLanguages": [
    "xml"
]

Hope it's what you were looking for 😃

@rzhao271
Copy link
Contributor

I forgot that workaround existed.
I still think that XML, even when Emmet is enabled, shouldn't output HTML abbreviations, though, which it still does.

@rzhao271 rzhao271 removed good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Feb 24, 2021
@rzhao271 rzhao271 modified the milestones: Backlog, March 2021 Mar 1, 2021
@rzhao271 rzhao271 removed the hackathon Label reserved for specific events label Mar 1, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 2, 2021

Reopening because it turns out that now the suggestion hides only when it exactly matches, e.g. a doesn't show the <a> suggestion but still shows all the other HTML suggestions.

@rzhao271 rzhao271 reopened this Mar 2, 2021
@roblourens roblourens added the verified Verification succeeded label Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@fbricon @roblourens @alexdima @rzhao271 @iamkacperwasik and others