Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfileの起動確認用CIを追加 #15626

Open
1 task
samunohito opened this issue Mar 8, 2025 · 2 comments
Open
1 task

Dockerfileの起動確認用CIを追加 #15626

samunohito opened this issue Mar 8, 2025 · 2 comments
Labels
🛠️Dev Development of Misskey itself 🐋docker Pull requests that update Docker code

Comments

@samunohito
Copy link
Member

Summary

context: #15623

リポジトリ直下のDockerfileを使って実際にコンテナを立ち上げるチェックをするCIを追加します。
現状存在しないはずなので…(実はあるとかであればそれでOK)

dockleによるイメージ確認のCIは既に存在していますが、これは異常終了するかどうかのチェックとしては使用できません(あくまでコンテナイメージの検査をするものらしい)。

Purpose

Dockerfileが動かないままリリースされるのを未然に防ぐ

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@samunohito samunohito added 🐋docker Pull requests that update Docker code 🛠️Dev Development of Misskey itself labels Mar 8, 2025
@samunohito
Copy link
Member Author

(.github/workflows/dockle.ymlのwebコンテナを起動する処理をベースに、docker compose psの結果からwebコンテナの起動状態をチェックするとかでいけそうな気がしています)

@eternal-flame-AD
Copy link
Contributor

We can potentially write pnpm run script (or just a MISSKEY_CI_EXIT_AFTER_HEALTHY=180) that exit after the service (send ourself a SIGTERM) has become healthy, and put a timeout on it and run it in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️Dev Development of Misskey itself 🐋docker Pull requests that update Docker code
Projects
Development

No branches or pull requests

2 participants