Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

トークンに有効期限を設定できるようになって欲しい #15646

Open
1 task
KisaragiEffective opened this issue Mar 11, 2025 · 5 comments
Open
1 task
Labels
✨Feature This adds/improves/enhances a feature

Comments

@KisaragiEffective
Copy link
Collaborator

Summary

一度きりのPlayなど、short-livedなユースケースで発行したトークンを使い終わった後に手動で失効させるのは忘れるリスクがあります。
現時点で被害にあったというわけではないですが…

Purpose

同上

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@KisaragiEffective KisaragiEffective added the ✨Feature This adds/improves/enhances a feature label Mar 11, 2025
@Sayamame-beans
Copy link
Member

strongly related: #10911

@eternal-flame-AD
Copy link
Contributor

My JWT proposal already has this feature:

#15570 (comment)

@KisaragiEffective
Copy link
Collaborator Author

JWTにしたら解決できるのはそうですが、そこに至るまでの道筋が長そうなので切り分けて考えてもいいかなという気持ちです

@eternal-flame-AD
Copy link
Contributor

I think it is good to have an interim solution too, but at the end of the day I think since JWT has official support for token expiration (actually most JWT libraries handle checking for us if we put the timestamp in exp) we should eventually converge to use one solution.

@eternal-flame-AD
Copy link
Contributor

eternal-flame-AD commented Mar 11, 2025

My hope was we can use meta:legacy policy I proposed to get a mostly drop in replacement for the current token, and gradually phase it out by dropping acceptance for tokens with meta:legacy policy as we implement more concrete features (sudo, SSO, more granular policy, etc)..

This way we can coordinate frontend adoption better as frontend-side we would be able to incrementally implement JWT token info handling instead of having to implement all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature
Projects
Development

No branches or pull requests

3 participants