Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #565

Closed
OrangeTux opened this issue Jan 9, 2024 · 7 comments
Closed

Drop support for Python 3.7 #565

OrangeTux opened this issue Jan 9, 2024 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@OrangeTux
Copy link
Contributor

OrangeTux commented Jan 9, 2024

Python 3.7 reached End of Life. Therefore, we can stop testing against this version.

We should:

  1. remove Python 3.7 from our workflow.
  2. raise the minimum Python supported Python version to 3.8
  3. remove the dependency on asynctest That fixes Replace unmaintained test dependency 'asynctest'  #433
  4. Remove Python 3.7 classifier from pyproject.toml
@OrangeTux OrangeTux added bug Something isn't working good first issue Good for newcomers labels Jan 9, 2024
@MuhammadHasnain77
Copy link

I have remove the version 3.7 from workflow check it out
also can you explain the other two issue

@OrangeTux
Copy link
Contributor Author

OrangeTux commented Jan 9, 2024

Among other things, pyproject.toml lists all dependencies of this project. That includes the Python version(s) that are supported by this project.

That file must be modified so minimum supported Python version is raised from Python 3.7 to Python 3.8. Read more at Poetry's documentation about dependency specification.

asynctest is a dependency required when using this project with Python 3.7. For all new Python version, this dependency is not required anymore. Since we drop support for Python 3.7, we can also remove the dependency asynctest completely. Here you can read more on restricting dependencies to specific Python version

@MuhammadHasnain77
Copy link

Thanks for describing the issue I will work on it.

@Jared-Newell-Mobility
Copy link
Contributor

Additional work to date can be found in #475

@MuhammadHasnain77
Copy link

Hi
Can you see my PR did i correct all the issues?

@Jared-Newell-Mobility
Copy link
Contributor

Jared-Newell-Mobility commented Jan 26, 2024

Associated PR #585

@Jared-Newell-Mobility
Copy link
Contributor

PR #585 created and approved for inclusion in v1.0.0 - so closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Development

No branches or pull requests

3 participants