Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerfile: bring heredocs out of labs #2574

Closed
tonistiigi opened this issue Jan 24, 2022 · 3 comments · Fixed by #2589
Closed

dockerfile: bring heredocs out of labs #2574

tonistiigi opened this issue Jan 24, 2022 · 3 comments · Fixed by #2589
Assignees
@jedevc
Labels
area/dockerfile
Milestone
v0.10.0

Comments

@tonistiigi
Copy link
Member

I think the heredocs implementation in 1.3 has been successful https://github.com/moby/buildkit/blob/dockerfile/1.3.1/frontend/dockerfile/docs/syntax.md#here-documents and would be ok to bring it out to stable channel in next release.

Any objections?

@jedevc @thaJeztah @AkihiroSuda
@tonistiigi tonistiigi added this to the v0.10.0 milestone Jan 24, 2022
@jedevc
Copy link
Member

jedevc commented Jan 24, 2022

🎉 awesome! Will be very excited to see this in stable!

I see #2442 has the same v0.10.0 milestone, I assume that would make it in as well?

@thaJeztah
Copy link
Member

Yes, I'm good with moving it to the stable front-end

@tonistiigi
Copy link
Member Author

@jedevc Could you make a PR for this?

@jedevc jedevc mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedevc jedevc

Labels
area/dockerfile
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Stabilize heredocs 🎉 jedevc/buildkit
3 participants
@tonistiigi @thaJeztah @jedevc