Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support input valueLink #142

Closed
colllin opened this issue Apr 1, 2016 · 3 comments
Closed

Please support input valueLink #142

colllin opened this issue Apr 1, 2016 · 3 comments

Comments

@colllin
Copy link

colllin commented Apr 1, 2016

These propTypes validations prevent the use of the valueLink prop on the input:

if (!inputProps.hasOwnProperty('value')) {

More about valueLink:

https://facebook.github.io/react/docs/two-way-binding-helpers.html

Please support valueLink, or consider delegating to a real <input> somewhere if you're not already, so that you don't need to re-implement or wrap native React functionality.

@moroshko
Copy link
Owner

moroshko commented Apr 8, 2016

I'm going to pass on this one because valueLink is deprecated since React 15.0.

@moroshko moroshko closed this as completed Apr 8, 2016
@colllin
Copy link
Author

colllin commented Apr 22, 2016

Lucky timing. Probably still a worthwhile suggestion not to re-implement input properties yourself. You could just pass them through.

Not supporting valueLink is just one side effect of that deeper issue.

@moroshko
Copy link
Owner

@colllin What input properties are we talking about. Autosuggest passes inputProps to the <input> element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants