-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to open the Extensions page with --start-url when running in Chrome #1979
Comments
It seems that Chrome does ignore chrome://extensions (also other chrome:// urls, like chrome://version) passed on the command line, e.g. executing on the command line
does start Chrome with the given url loaded in the first tab On the contrary:
does start Chrome but it doesn't load that chrome url in the first tab. I have the feeling that this may be an intended behavior, I briefly looked if Chrome does provide a command line flag to override this behavior, but at the moment I haven't spotted any that may be related. We may have to close this as a wontfix if we don't have a way to tell Chrome to allow chrome:// urls as start urls, but for now I'm keeping this open to take another look and think a bit if there may be other options to achieve that. |
Chrome extensions can open many |
that's true, and I just verified that |
I'll mentor this bug. |
Hi @Rob--W ! May I work on this bug? |
@DeepikaKaranji Taking a step back, the core of the issue is that trying to open
web-ext/src/extension-runners/chromium.js Lines 153 to 227 in 9353e26
With those two code snippets, you can probably get started. Let me know if there are still questions! |
Hey @DeepikaKaranji, how's it going with this issue? |
Hello @caitmuenster , I was AFK for a bit, I've set up the environment, and I have gotten started with this issue yesterday. |
How I thought I'll approach this was:
What I've understood/ not understood so far:
|
This step is incorrect. I think that the misunderstanding is that you think that you need to change the behavior of how
|
Hey @DeepikaKaranji, how's it going with this issue? |
Hi @caitmuenster ! |
No worries at all, @DeepikaKaranji! :) Good luck on your exams! |
@Rob--W @caitmuenster can I work on this issue, I have a rough idea about the solution now after reading the above conversation... |
Hi @ariain , I have already started working on this, will make the PR soon. I hope that is okay. Thanks for understanding :) |
Hi @ariain, there are some other good-first-bugs in our add-ons repositories if you'd like to work on one of those. It looks like this issue on the code manager repo is currently open, as is this issue in the webextension-polyfill repo. |
@DeepikaKaranji I totally understand... @caitmuenster I would like to work on them, thanks for suggesting... |
@Rob--W
I added the below snippet at line 221 in chromium.js:
I called it PseudoExtension because from you have mentioned that Extensions are able launch "chrome://" URLs. But in this case, I need to prevent that from happening, and pass the "chrome://" url to the createReloadManagerExtension helper extension. The test however does not work, but I just wanted to check if I'm on the right track. Thank you! |
The test expectation is incorrect. The I don't know what you're trying to do with the |
Alright, I'll do that, thanks. |
Hey @DeepikaKaranji, just wanted to check in with you about this issue. Are you still interested in working on it? |
Hey @DeepikaKaranji, we are going to open this up to other contributors since we haven't heard from you in awhile. If you'd like to finish it off, please feel free to come back to it! O |
Hello @caitmuenster, I was looking for good-first-issues in the add-ons repositories and this one seemed ideal - may I work on it? |
Go for it, @CatWithNineLives! If you need any help, please tag [@]Rob--W in a comment. |
Hey @CatWithNineLives, we haven't heard from you in awhile so we're going to open this up to other contributors. If you want to work on it, please feel free to submit a PR. :) |
Hi @caitmuenster, I saw this issue a few days ago and realized that it's open for contribution. I would like to work on this bug and hopefully fix it if I may? :) |
Hey @Rob--W. I have looked a bit in the code and based on your comments above, I believe I have an understanding how to fix this bug. I have made some changes at chromium.js to detect presence of chrome://extensins in the url array list, and have added necessary code for Websocket communications also at chromium.js and chromium.js My issue at the moment is that I can't seem to find the appropriate location in code to invoke the new websocket communication I tried to confirm this by testing what happens when I swap the current websocket message with the new one I created when R is pressed, so that whenever you press R to reload it sends the new message instead of I'm not sure if there is some extra action taking place outside of chromium.js before which chrome is fully loaded, and asynchronous JavaScript isn't my strong side, so I'm a bit confused in the multitude of asyncs and promises used in code, so I'd appreciate if you could give me some tips. My current commit is available at https://github.com/kodergeek/web-ext/blob/bug-1979/src/extension-runners/chromium.js |
You could wait for the first WebSocket connection and post the initialization message to open the extension tab. Feel free to open a pull request for work-in-progress code; then it is easier to provide feedback at specific lines. |
Thanks for your feedback. I have created a pull request so you can point to specific lines easily. |
Is this a feature request or a bug?
Bug
What is the current behavior?
Running an extension in Chrome with
--start-url "chrome://extensions"
(or"about:extensions"
) fails to open the Extensions page. (The extensions page is useful for inspecting your extension's background page.)Using
--start-url
to openabout:debugging
does work in Firefox.Versions
Chrome 84
web-ext 5.0.0
The text was updated successfully, but these errors were encountered: