Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust v1.70.0 ambiguous re exports #1974

Closed
andreievg opened this issue Jul 7, 2023 · 1 comment · Fixed by #1988
Closed

Rust v1.70.0 ambiguous re exports #1974

andreievg opened this issue Jul 7, 2023 · 1 comment · Fixed by #1988
Labels
Build Tested: Dev Issue cannot be tested in build but tested by dev

Comments

@andreievg
Copy link
Collaborator

andreievg commented Jul 7, 2023

With latest rust getting lots of ambiguous re-export errors, I think introduces here: rust-lang/rust#109538 for v1.70.0

It sounds like when same type names are re-exported (like DeleteError which is exported in multiple graphql definitions).

Do we silence it ? Or do we amend exports ? I would assume when those types are used they are qualified (use SomeType; SomeType::DeleteError) with full name rather then imported, so should be pretty easy to remove the re-export ?

I think it's glob exports, so pub(crate) them ?

@clemens-msupply
Copy link
Contributor

clemens-msupply commented Jul 11, 2023

Yes I would fix the exports by changing:

mod create_requisition_shipment;
pub use create_requisition_shipment::*;

// to just:
pub(crate) mod create_requisition_shipment;

and then fixing the imports...

@nishaDangol-Sussol nishaDangol-Sussol added the Build Tested: Dev Issue cannot be tested in build but tested by dev label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Tested: Dev Issue cannot be tested in build but tested by dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants