Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display GPS co-ordinates #6855

Open
jmbrunskill opened this issue Mar 5, 2025 · 10 comments
Open

Display GPS co-ordinates #6855

jmbrunskill opened this issue Mar 5, 2025 · 10 comments
Assignees
Labels
feature: GAPS needs design Needs PO/UI/UX designer input Team Piwakawaka James, Carl, John, Zachariah, Ferg
Milestone

Comments

@jmbrunskill
Copy link
Contributor

jmbrunskill commented Mar 5, 2025

Add current GPS co-ordinate to settings page

Image

Note: for now this will just be display only and the location for capturing the GPS will likely change.

@jmbrunskill jmbrunskill added this to the v2.7.0 milestone Mar 5, 2025
@GeronimoJohn GeronimoJohn self-assigned this Mar 6, 2025
@GeronimoJohn GeronimoJohn added the Team Piwakawaka James, Carl, John, Zachariah, Ferg label Mar 6, 2025
@mark-prins mark-prins added the needs design Needs PO/UI/UX designer input label Mar 6, 2025
@mariyamsupply
Copy link
Contributor

Setting page or Help page??

What does 'Capture location now' button do? Updating your live location or Coping the one presented?

@adamdewey
Copy link
Contributor

What does 'Capture location now' button do? Updating your live location or Coping the one presented?

It's supposed to save the GPS values to the current Store so that they can be used to identify where the store is located

@mariyamsupply
Copy link
Contributor

After chatting w James and Mark I suggest we put GPS coordinates in Setting together with Store properties (taking them out from a footer modal) . Footer is a weird place for it.
so the GPS location can go to the same place.

Image Image

--

the button should be called 'Update live location' and update coordinates when clicked.
(we already present the location, just to make sure it's still correct).
plus 'Copy' coordinates could be useful.

Image Image

@adamdewey
Copy link
Contributor

Hmm, I kind of disagree - I find it weird to have the store properties mixed up with the administrative settings?

Can't we put them in Manage > Facilities?

@mark-prins
Copy link
Collaborator

that would require adding Manage for all users, and having a menu item with only one item in it. You'd also have Facilities with only on facility in it. We have issues with the length of the menu already, and are trying to reduce the size of it. The Manage menu item is only shown on the central server - the intention of that menu item is for the management tasks (edit users, stores etc)

as discussed - the idea with the footer facility name having an edit is analogous to editing a user profile by clicking on your username / icon.

Open to options - would prefer not to add more menu items though if we can avoid that.

@GeronimoJohn
Copy link
Contributor

GeronimoJohn commented Mar 12, 2025

Finally heading back into this ticket.

Going to add GPS Coords in Store Properties as a start. Will only show it if open through Store Properties if that makes sense.

As to where we should move Store Properties. It was my first time initialising GAPS and going through the feature if you could say that. If I were to look for a Store Properties or any general properties of some sort my initial hunch would be to go to settings.

@jmbrunskill
Copy link
Contributor Author

Thanks @GeronimoJohn, I think @mark-prins wants to keep it under store properties in the bottom bar for now.
Maybe we could do the full screen modal and the left and right aligned columns as per Mariya's design though?

@GeronimoJohn
Copy link
Contributor

Sounds good to me!

@mark-prins
Copy link
Collaborator

we haven't reached an agreement on where to put the store properties yet!
the full screen modal is a great idea 🙏
that gets us working without spending too much time on it

@adamdewey
Copy link
Contributor

One minor gripe about the alignment is that it's hard to distinguish the right-aligned numbers from the drop down arrows so it's hard to spot if there are any empty fields.

Are there any easy alternatives? Left-aligning numbers, different colours between numbers and arrows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: GAPS needs design Needs PO/UI/UX designer input Team Piwakawaka James, Carl, John, Zachariah, Ferg
Projects
None yet
Development

No branches or pull requests

5 participants