git-lfs stopped working with msys2-runtime-3.5.4 update

[c00ldchan]

Description / Steps to reproduce the issue

1. Install msys2-runtime-3.5.4-1 or newer
2. Install git and mingw-w64-x86_64-git-lfs
3. Try pulling any LFS repo via ssh

Expected behavior

Files managed by git-lfs are downloaded

Actual behavior

git-lfs hangs at the git-lfs-authenticate step, which involves reading ssh output. With GIT_TRACE=1 it hangs after printing this line:
exec: ssh '[email protected]' 'git-lfs-authenticate username/repository.git download'

Downgrading to msys2-runtime-3.5.3-5 or manually replacing msys2-runtime.dll with the one from v3.5.3-5 resolves the issue.

Verification

• I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

MINGW64_NT-10.0-19045

Are you willing to submit a PR?

No response

[eabase]

I thought git was broken for all MSYS?
At least that's what people say, and why they install git for windows.

If this is not true, please let us all know, and update all the recent stack-overflows stating otherwise.

[orzzzp]

I met the same issue.

[CaffeineViking]

I'm also running into this when trying to pull a repo with some updated LFS files. Adding GIT_TRACE=1 before git pull and I can see that it's getting stuck on: git-lfs-transfer download

@eabase I've exclusively been using git on MSYS for 5+ years w/o issues, including LFS, so it's definitely been working previously!

[c00ldchan]

Same here -- I've been using MSYS2 git for a while now with literally zero issues, except for some apparent general sluggishness.

It seems the fix is here: git-for-windows/msys2-runtime#75
Applying the same patch to msys2-runtime resolved the issue on my end.

[zdm]

Is it possible to merge this patch?
Git unable to push if git-lfs is installed.

[jstine35]

Moreover my analysis is that the original change that introduced this bug is both philosophically and technically incorrect and should likely be reverted regardless of its impact on this specific issue.

I thought git was broken for all MSYS? At least that's what people say, and why they install git for windows.

If this is not true, please let us all know, and update all the recent stack-overflows stating otherwise.

Git on MSYS2 works fine. I have been using vanilla MSYS2 GIT since 2022 without issues, and I have worked on various persistent (non-dockerized) runner setups that rely exclusively on MSYS2 GIT for all git operations needed to populate runners and execute jobs. Eg, setups where MSYS2 images run with cleanly sandboxed PATH/Environ and have little or no reliance on Windows inherited environment or applications.

The only thing that's sort of missing from MSYS2 GIT that Git for Windows offers is the preferred Git Credential Manager for Windows (preferred depending on one's setup and workflow). It is trivial to download and install that into a given MSYS2 image and it works as expected.

As for updating all StackOverflows... that seems a bit out of scope for resolution of this present issue?

[jeremyd2019]

Moreover my analysis is that the original change that introduced this bug is both philosophically and technically incorrect and should likely be reverted regardless of its impact on this specific issue.

Please take this analysis to [email protected]. I'd very much like it fixed upstream, but I haven't investigated this personally to be able to advocate for it sufficiently myself.

[jeremyd2019]

I've sent @dscho's patch from git-for-windows/msys2-runtime#75 to cygwin-patches for discussion: https://inbox.sourceware.org/cygwin-patches/[email protected]/T/#u

[dscho]

I've sent @dscho's patch from git-for-windows/msys2-runtime#75 to cygwin-patches for discussion: https://inbox.sourceware.org/cygwin-patches/[email protected]/T/#u

@jeremyd2019 wow, it was already pushed... (to main, not to cygwin-3_5-branch, though).

[jeremyd2019]

They're not planning to make more 3.5 releases, so they're not pushing to cygwin-3_5-branch anymore.