Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the choice of the reference entity in the list. #4

Closed
rCarto opened this issue Nov 13, 2018 · 4 comments
Closed

Enhance the choice of the reference entity in the list. #4

rCarto opened this issue Nov 13, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@rCarto
Copy link
Contributor

rCarto commented Nov 13, 2018

I am not sure in what order are the IDs sorted. The matrix rows order? the point layer rows order?
It is difficult to select a single ID in a list of several hundreds unordered records...

Anyway thank you for this great plugin ! So easy to use :-)

++

@mthh
Copy link
Owner

mthh commented Nov 13, 2018

Hum good catch..
The list of entity is currently based on the matrix rows (which already makes sense regarding to future improvements such as #3). But iirc it's stocked in a dict, so I guess depending on your python version it might be totally unordered (in CPython dict are maintaining order of insertion as an implementation detail in 3.6 and as a language feature in 3.7).

I will take care to fill the reference entity menu with features ID respecting the matrix order... it will already be an improvement but I guess the selection of a single ID in a list of several hundred of records (even if ordered) will remain difficult !

@mthh mthh added the enhancement New feature or request label Nov 13, 2018
@mthh
Copy link
Owner

mthh commented Nov 14, 2018

What I had in mind was a bunch of INSEE code (hence the difficult selection even if preserving the matrix order).
But maybe we could simply sort the list alphabeticaly or from smallest to largest value (if ID are numerics)?

Any opinion ?

@rCarto
Copy link
Contributor Author

rCarto commented Nov 14, 2018

I would go for alphabetical order for character IDs and smallest to largest values for numerical IDs. Chance are the matrix order is rarely carefully thought....

@rCarto rCarto closed this as completed Nov 14, 2018
@rCarto rCarto reopened this Nov 14, 2018
@mthh
Copy link
Owner

mthh commented Nov 22, 2018

The new version (0.2) is now on Qgis Python Plugins Repository : http://plugins.qgis.org/plugins/dist_cartogram/
It can also be downloaded from https://github.com/mthh/QgisDistanceCartogramPlugin/releases/tag/v0.2

@mthh mthh closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants