Merge pull request #119 from aequitas/ocspmemoryleak

nabla-c0d3 · web-flow · commit fe914c050ca3 · 2024-06-22T14:55:45.000+02:00
Fix memory leak in OCSP response basic_verify
diff --git a/nassl/_nassl/nassl_OCSP_RESPONSE.c b/nassl/_nassl/nassl_OCSP_RESPONSE.c
@@ -139,6 +139,7 @@ static PyObject* nassl_OCSP_RESPONSE_basic_verify(nassl_OCSP_RESPONSE_Object *se
 
     verifyRes = OCSP_basic_verify(basicResp, NULL, trustedCAs, 0);
     OCSP_BASICRESP_free(basicResp);
+    X509_STORE_free(trustedCAs);
     if (verifyRes <= 0)
     {
         return raise_OpenSSL_error();

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,7 @@ static PyObject* nassl_OCSP_RESPONSE_basic_verify(nassl_OCSP_RESPONSE_Object *se`
`139`	`139`
`140`	`140`	`verifyRes = OCSP_basic_verify(basicResp, NULL, trustedCAs, 0);`
`141`	`141`	`OCSP_BASICRESP_free(basicResp);`
	`142`	`+ X509_STORE_free(trustedCAs);`
`142`	`143`	`if (verifyRes <= 0)`
`143`	`144`	`{`
`144`	`145`	`return raise_OpenSSL_error();`