Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing public holiday #749

Open
OtterKring opened this issue Jan 21, 2025 · 2 comments
Open

Missing public holiday #749

OtterKring opened this issue Jan 21, 2025 · 2 comments

Comments

@OtterKring
Copy link

Affected country

Austria

Affected public holiday

Easter Sunday, Pentecost Sunday

Source of the information

https://de.wikipedia.org/wiki/Gau%C3%9Fsche_Osterformel

More information

It might be intentional, since sundays are no workdays anyway, nevertheless I found that Easter Sunday and Pentecost Sunday, both public holidays in Austria, are not listed when calling the API.

@OtterKring OtterKring added the bug label Jan 21, 2025
@tinohager
Copy link
Member

Until now, public holidays on a Sunday have not provided any added value. Do you have a specific case or is it purely a matter of principle?

@OtterKring
Copy link
Author

I guess it is a matter of principle. If you have the information, why not return it and leave it to the "end user" if they need it or not?

May current use case:
I am working on an app showing the days of a month in a list, including weekends, replacing the weekday names with holiday names if the day is a holiday. While calculating Austria's holidays in code is very straight forward, I require other options to get this information for other countries. Otherwise I would have to do the global rollout without the holiday features.
The app is used to manage our employee's HomeOffice days. They are allowed, though, to "activate" a weekend day or holiday as a workday if the shifts require it or e.g. IT uses them as a service window to apply patches.
Again, yes, it would not do make me handle sundays differently if they are holidays, too, but I am sure, users would come back to me complaining about the "forgotten" holiday in the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants