-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another problem on tracing (ARM) chrome #721
Comments
$ cat src/third_party/libpng/pngrtran.c
...
void PNGFAPI
png_set_gamma_fixed(png_structrp png_ptr, png_fixed_point scrn_gamma,
png_fixed_point file_gamma)
{
png_debug(1, "in png_set_gamma_fixed");
if (png_rtran_ok(png_ptr, 0) == 0)
return;
scrn_gamma = translate_gamma_flags(png_ptr, scrn_gamma, 1/*screen*/);
file_gamma = translate_gamma_flags(png_ptr, file_gamma, 0/*file*/);
if (file_gamma <= 0)
png_error(png_ptr, "invalid file gamma in png_set_gamma");
if (scrn_gamma <= 0)
png_error(png_ptr, "invalid screen gamma in png_set_gamma");
png_ptr->colorspace.gamma = file_gamma;
png_ptr->colorspace.flags |= PNG_COLORSPACE_HAVE_GAMMA;
png_ptr->screen_gamma = scrn_gamma;
}
...
static int
png_rtran_ok(png_structrp png_ptr, int need_IHDR)
{
if (png_ptr != NULL)
{
if ((png_ptr->flags & PNG_FLAG_ROW_INIT) != 0)
png_app_error(png_ptr, "invalid after png_start_read_image or png_read_update_info");
else if (need_IHDR && (png_ptr->mode & PNG_HAVE_IHDR) == 0)
png_app_error(png_ptr, "invalid before the PNG header has been read");
else
{
png_ptr->flags |= PNG_FLAG_DETECT_UNINITIALIZED;
return 1; /* Ok */
}
}
return 0; /* no png_error possible! */
} |
|
01ce434c <wk_png_set_gamma_fixed>:
1ce434c: b5f8 push {r3, r4, r5, r6, r7, lr}
1ce434e: af00 add r7, sp, #0
1ce4350: b500 push {lr}
1ce4352: f60c c04c blx ef03ec <__gnu_mcount_nc@plt>
1ce4356: 460d mov r5, r1
1ce4358: 2100 movs r1, #0
1ce435a: 4616 mov r6, r2
1ce435c: 4604 mov r4, r0
1ce435e: f7ff fdaf bl 1ce3ec0 <png_rtran_ok>
1ce4362: b378 cbz r0, 1ce43c4 <wk_png_set_gamma_fixed+0x78>
1ce4364: f647 1360 movw r3, #31072 ; 0x7960
1ce4368: f6cf 73fe movt r3, #65534 ; 0xfffe
1ce436c: 429d cmp r5, r3
1ce436e: bf18 it ne
1ce4370: f1b5 3fff cmpne.w r5, #4294967295 ; 0xffffffff
1ce4374: d127 bne.n 1ce43c6 <wk_png_set_gamma_fixed+0x7a>
1ce4376: f645 3560 movw r5, #23392 ; 0x5b60
1ce437a: f8d4 31c0 ldr.w r3, [r4, #448] ; 0x1c0
1ce437e: f2c0 0503 movt r5, #3
1ce4382: f443 5380 orr.w r3, r3, #4096 ; 0x1000
1ce4386: f8c4 31c0 str.w r3, [r4, #448] ; 0x1c0
1ce438a: f647 1360 movw r3, #31072 ; 0x7960
1ce438e: f6cf 73fe movt r3, #65534 ; 0xfffe
1ce4392: 429e cmp r6, r3
1ce4394: bf18 it ne
1ce4396: f1b6 3fff cmpne.w r6, #4294967295 ; 0xffffffff
1ce439a: d123 bne.n 1ce43e4 <wk_png_set_gamma_fixed+0x98>
1ce439c: f24b 168f movw r6, #45455 ; 0xb18f
1ce43a0: f8d4 31c0 ldr.w r3, [r4, #448] ; 0x1c0
1ce43a4: f443 5380 orr.w r3, r3, #4096 ; 0x1000
1ce43a8: f8c4 31c0 str.w r3, [r4, #448] ; 0x1c0
1ce43ac: 2d00 cmp r5, #0
1ce43ae: dd2e ble.n 1ce440e <wk_png_set_gamma_fixed+0xc2>
1ce43b0: f8b4 340e ldrh.w r3, [r4, #1038] ; 0x40e
1ce43b4: f8c4 63c4 str.w r6, [r4, #964] ; 0x3c4
1ce43b8: f043 0301 orr.w r3, r3, #1
1ce43bc: f8c4 52cc str.w r5, [r4, #716] ; 0x2cc
1ce43c0: f8a4 340e strh.w r3, [r4, #1038] ; 0x40e
1ce43c4: bdf8 pop {r3, r4, r5, r6, r7, pc}
1ce43c6: f643 42b0 movw r2, #15536 ; 0x3cb0
1ce43ca: f245 03ac movw r3, #20652 ; 0x50ac
1ce43ce: f6cf 72ff movt r2, #65535 ; 0xffff
1ce43d2: f115 0f02 cmn.w r5, #2
1ce43d6: bf18 it ne
1ce43d8: 4295 cmpne r5, r2
1ce43da: f2c0 0302 movt r3, #2
1ce43de: bf08 it eq
1ce43e0: 461d moveq r5, r3
1ce43e2: e7d2 b.n 1ce438a <wk_png_set_gamma_fixed+0x3e>
1ce43e4: f643 43b0 movw r3, #15536 ; 0x3cb0
1ce43e8: f6cf 73ff movt r3, #65535 ; 0xffff
1ce43ec: f116 0f02 cmn.w r6, #2
1ce43f0: bf18 it ne
1ce43f2: 429e cmpne r6, r3
1ce43f4: bf04 itt eq
1ce43f6: f240 1675 movweq r6, #373 ; 0x175
1ce43fa: f2c0 0601 movteq r6, #1
1ce43fe: d0d5 beq.n 1ce43ac <wk_png_set_gamma_fixed+0x60>
1ce4400: 2e00 cmp r6, #0
1ce4402: dcd3 bgt.n 1ce43ac <wk_png_set_gamma_fixed+0x60>
1ce4404: 4904 ldr r1, [pc, #16] ; (1ce4418 <wk_png_set_gamma_fixed+0xcc>)
1ce4406: 4620 mov r0, r4
1ce4408: 4479 add r1, pc
1ce440a: f7fa f99f bl 1cde74c <wk_png_error>
1ce440e: 4903 ldr r1, [pc, #12] ; (1ce441c <wk_png_set_gamma_fixed+0xd0>)
1ce4410: 4620 mov r0, r4
1ce4412: 4479 add r1, pc
1ce4414: f7fa f99a bl 1cde74c <wk_png_error>
1ce4418: 03f97d08 .word 0x03f97d08
1ce441c: 03f97d22 .word 0x03f97d22 |
After trying to use
|
It looks normal until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After resolving #714 by skipping
dlsym
, I got another problem.T1. tracing prebuilt chrome with
--force
without--nest-libcall
T2. tracing prebuilt chrome with
--nest-libcall
It runs more than before, but got stuck during launching chrome.
T3. tracing
-pg
compiled chrome with--nest-libcall
(replayed only master thread)It gets finished unexpectedly and its trace result is as follows:
Here is the debug message.
The text was updated successfully, but these errors were encountered: