Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG Report] Confirmation with [Y/n] should default to "yes" #146

Closed
Crocmagnon opened this issue May 7, 2024 · 1 comment
Closed

[BUG Report] Confirmation with [Y/n] should default to "yes" #146

Crocmagnon opened this issue May 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Crocmagnon
Copy link

Crocmagnon commented May 7, 2024

gup version

$ gup version
gup version v0.25.2 (under Apache License version 2.0)

Description (About the problem)

When removing a binary, a confirmation is asked with [Y/n]. This syntax is commonly used to denote that "yes" is the default answer when just sending Enter.
gup however doesn't do anything when only Enter is sent. It re-asks the same question.

Steps to reproduce

$ gup remove go1.22.2
gup:CHECK: remove /Users/gaugendre/go/bin/go1.22.2? [Y/n]
gup:CHECK: remove /Users/gaugendre/go/bin/go1.22.2? [Y/n] y
gup:INFO : removed /Users/gaugendre/go/bin/go1.22.2

Expected behavior

Either set a default behavior according to the capitalized choice (preferred), or change the string to read [y/n]

@Crocmagnon Crocmagnon added the bug Something isn't working label May 7, 2024
@nao1215
Copy link
Owner

nao1215 commented May 8, 2024

@Crocmagnon
Thank you for writing the bug report.
To be honest, I didn't know about that rule. It has been fixed in PR #147 .

@nao1215 nao1215 closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants