Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting-stack.processors.test-runner/test!: return a useful value #176

Open
vemv opened this issue Mar 15, 2021 · 2 comments
Open

formatting-stack.processors.test-runner/test!: return a useful value #176

vemv opened this issue Mar 15, 2021 · 2 comments

Comments

@vemv
Copy link
Contributor

vemv commented Mar 15, 2021

Context

test! currently returns the fixed value nil. This makes it a limited primitive for creating more substantial functionality.

Task

Make it return a boolean depending on whether the test suite passed

Acceptance criteria

A boolean? is returned no matter what, even in face of exceptions (as they are common in WIP/failing/flaky tests)

@thumbnail
Copy link
Member

Using a boolean now prevents expansion in the future.

What do you think about returning a map? It can yield :result? now, and possibly reports or tested-files in a later iteration.

@vemv
Copy link
Contributor Author

vemv commented Mar 15, 2021

Yeah returning the same map that clojure.test does seems best 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants