Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walredo bench should be switched to a single multi-threaded runtime #6648

Closed
Tracked by #6628
problame opened this issue Feb 6, 2024 · 2 comments
Closed
Tracked by #6628

walredo bench should be switched to a single multi-threaded runtime #6648

problame opened this issue Feb 6, 2024 · 2 comments
Labels
a/performance Area: relates to performance of the system c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions

Comments

@problame
Copy link
Contributor

problame commented Feb 6, 2024 •
edited
Loading

It currently spawns single-threaded runtimes on n threads (where n is controlled by criterion).

Instead, spawn a multi-threaded runtime where n clients run, all pounding against one walredo manager.
@problame problame mentioned this issue Feb 6, 2024
Closed
1 task
@problame problame added c/storage/pageserver Component: storage: pageserver a/performance Area: relates to performance of the system m/good_first_issue Moment: when doing your first Neon contributions labels Feb 6, 2024
@calinanca99 calinanca99 mentioned this issue Feb 13, 2024
Merged
5 tasks
@calinanca99
Copy link
Contributor

Hi @problame! Opened #6743 to address this. Would appreciate your review! 🙏🏻

@problame
Copy link
Contributor Author

Thanks for your contribution, @calinanca99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/performance Area: relates to performance of the system c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@problame @calinanca99