Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry querying funding transaction status after timeout (also persist unconfirmed funding channel info) #146

Closed
contrun opened this issue Aug 26, 2024 · 1 comment

Comments

@contrun
Copy link
Collaborator

contrun commented Aug 26, 2024

Currently, the funding transaction has to have 4 confirmations in 60s https://github.com/contrun/fiber/blob/0f6c5f5e18532a1b3b520788eb9168cbbace179d/src/fiber/network.rs#L1302-L1307 https://github.com/contrun/fiber/blob/0f6c5f5e18532a1b3b520788eb9168cbbace179d/src/fiber/network.rs#L63

We need to enlarge this time duration so that we can successfully process funding transaction confirmation event. This unconfirmed funding transaction information has to be persisted, because otherwise we can't handle the node being shutdown immediately after broadcasting funding transaction while before funding transaction being confirmed.

@doitian
Copy link
Member

doitian commented Jan 2, 2025

Will be handled in #437 and #438

@doitian doitian closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants