Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate or replace librandom::binomial_randomdev #1296

Closed
heplesser opened this issue Sep 25, 2019 · 0 comments · Fixed by #1549
Closed

Deprecate or replace librandom::binomial_randomdev #1296

heplesser opened this issue Sep 25, 2019 · 0 comments · Fixed by #1549
Assignees
@heplesser
Labels
I: Behavior changes Introduces changes that produce different results for some users S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Milestone
NEST 3.0

Comments

@heplesser
Copy link
Contributor

NEST uses the binomial random deviate generator provided by GSL if built with GSL. This works fine. If built without GSL, NEST uses an algorithm included in librandom, which precomputes a table using an algorithm that is Theta(N^2) in the number of outcomes, leading to prohibitive runtimes for, e.g., fixed-total-number connectivity for large numbers of connections. We should remove this generator and simply require GSL.
@heplesser heplesser added ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: Behavior changes Introduces changes that produce different results for some users labels Sep 25, 2019
@hakonsbm hakonsbm added this to the NEST 3.0 milestone Jan 10, 2020
@heplesser heplesser mentioned this issue Feb 21, 2020
Closed
@heplesser heplesser self-assigned this Apr 7, 2020
@heplesser heplesser removed ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL labels Apr 7, 2020
@hakonsbm hakonsbm mentioned this issue Apr 24, 2020
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heplesser heplesser

Labels
I: Behavior changes Introduces changes that produce different results for some users S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
NEST 3.0
Development

Successfully merging a pull request may close this issue.

Modernize random number generator setup hakonsbm/nest-simulator
2 participants
@heplesser @hakonsbm