Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Node::calibrate() method #2060

Closed
clinssen opened this issue Jun 8, 2021 · 1 comment · Fixed by #2336
Closed

Refactor Node::calibrate() method #2060

clinssen opened this issue Jun 8, 2021 · 1 comment · Fixed by #2336
Assignees
@pnbabu
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@clinssen
Copy link
Contributor

clinssen commented Jun 8, 2021

The calibrate() method should be renamed to something more descriptive, such as recompute_internal_variables().

It should be removed from the Node base class and no longer be called from NodeManager::prepare_node(). Instead, it should be a private method, that individual Node classes call internally from three places: their constructor, their copy constructor, and SetStatus().
@clinssen clinssen added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Jun 8, 2021
@stinebuu stinebuu mentioned this issue Jun 8, 2021
Closed
@stinebuu stinebuu added the I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know label Jun 8, 2021
@heplesser heplesser added this to the NEST 3.2 milestone Jun 30, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Sep 3, 2021
@terhorstd terhorstd removed this from the NEST 3.2 milestone Jan 17, 2022
@pnbabu pnbabu mentioned this issue Mar 10, 2022
Merged
@jougs jougs removed the stale Automatic marker for inactivity, please have another look here label Mar 21, 2022
@jessica-mitchell jessica-mitchell moved this to Done in Models Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnbabu pnbabu

Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Models
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename calibrate method to pre_run_hook pnbabu/nest-simulator
6 participants
@heplesser @jougs @terhorstd @stinebuu @clinssen @pnbabu