Skip to content

Commit 96aba74

Browse files
committed
Remove useless INCREF of arguments
1 parent 94ee309 commit 96aba74

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/nrnpython/nrnpy_nrn.cpp

+2-9
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,8 @@ static Object* pysec_cell(Section* sec) {
191191
}
192192

193193
static int NpySObj_contains(PyObject* s, PyObject* obj, const char* string) {
194-
/* Checks is provided PyObject* s matches obj.<string> */
195-
auto pyobj = nb::borrow(obj); // keep refcount+1 during use
194+
/* Checks if provided PyObject* s matches obj.<string> */
195+
nb::handle pyobj{obj};
196196
if (!nb::hasattr(pyobj, string)) {
197197
return 0;
198198
}
@@ -1498,7 +1498,6 @@ static PyObject* NPySecObj_insert(NPySecObj* self, PyObject* args) {
14981498
// if called with an object that has an insert method, use that
14991499
PyObject* tpyobj;
15001500
if (PyArg_ParseTuple(args, "O", &tpyobj)) {
1501-
auto _tpyobj_tracker = nb::borrow(tpyobj);
15021501
// Returned object to be discarded
15031502
auto out_o = nb::steal(PyObject_CallMethod(tpyobj, "insert", "O", (PyObject*) self));
15041503
if (!out_o.is_valid()) {
@@ -1975,7 +1974,6 @@ static PyObject* section_getattro(NPySecObj* self, PyObject* pyname) {
19751974
Section* sec = self->sec_;
19761975
CHECK_SEC_INVALID(sec);
19771976
PyObject* rv;
1978-
auto _pyname_tracker = nb::borrow(pyname); // keep refcount+1 during use
19791977
Py2NRNString name(pyname);
19801978
char* n = name.c_str();
19811979
if (name.err()) {
@@ -2035,7 +2033,6 @@ static int section_setattro(NPySecObj* self, PyObject* pyname, PyObject* value)
20352033
}
20362034
PyObject* rv;
20372035
int err = 0;
2038-
auto _pyname_tracker = nb::borrow(pyname); // keep refcount+1 during use
20392036
Py2NRNString name(pyname);
20402037
char* n = name.c_str();
20412038
if (name.err()) {
@@ -2188,7 +2185,6 @@ static PyObject* segment_getattro(NPySegObj* self, PyObject* pyname) {
21882185
CHECK_SEC_INVALID(sec)
21892186

21902187
Symbol* sym;
2191-
auto _pyname_tracker = nb::borrow(pyname); // keep refcount+1 during use
21922188
Py2NRNString name(pyname);
21932189
char* n = name.c_str();
21942190
if (name.err()) {
@@ -2330,7 +2326,6 @@ static int segment_setattro(NPySegObj* self, PyObject* pyname, PyObject* value)
23302326
PyObject* rv;
23312327
Symbol* sym;
23322328
int err = 0;
2333-
auto _pyname_tracker = nb::borrow(pyname); // keep refcount+1 during use
23342329
Py2NRNString name(pyname);
23352330
char* n = name.c_str();
23362331
if (name.err()) {
@@ -2480,7 +2475,6 @@ static PyObject* mech_getattro(NPyMechObj* self, PyObject* pyname) {
24802475
Section* sec = self->pyseg_->pysec_->sec_;
24812476
CHECK_SEC_INVALID(sec)
24822477
CHECK_PROP_INVALID(self->prop_id_);
2483-
auto _pyname_tracker = nb::borrow(pyname); // keep refcount+1 during use
24842478
Py2NRNString name(pyname);
24852479
char* n = name.c_str();
24862480
if (!n) {
@@ -2574,7 +2568,6 @@ static int mech_setattro(NPyMechObj* self, PyObject* pyname, PyObject* value) {
25742568
}
25752569

25762570
int err = 0;
2577-
auto _pyname_tracker = nb::borrow(pyname); // keep refcount+1 during use
25782571
Py2NRNString name(pyname);
25792572
char* n = name.c_str();
25802573
if (name.err()) {

0 commit comments

Comments
 (0)